<html><head><style>body{font-family:Helvetica,Arial;font-size:13px}</style></head><body style="word-wrap:break-word;line-break:after-white-space"><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">Hi Gio,</div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto"><br></div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">Would we still use vagrant and full browsers when running testem locally? Or would we switch that to the same setup as CI as well?</div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto"><br></div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">Thanks</div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">Justin</div> <br> <div id="bloop_sign_1530624758980036096" class="bloop_sign"></div> <br><p class="airmail_on">On June 29, 2018 at 6:17:50 PM, Tirloni, Giovanni (<a href="mailto:gtirloni@ocadu.ca">gtirloni@ocadu.ca</a>) wrote:</p> <blockquote type="cite" class="clean_bq"><span><div><div></div><div>Closed that PR as it was getting too polluted with all the different things I was trying.
<br>
<br>Here's a new and simplified PR: <a href="https://github.com/fluid-project/infusion/pull/910">https://github.com/fluid-project/infusion/pull/910</a>
<br>
<br>Thanks!
<br>
<br>On 06/18/2018 02:09 PM, Tirloni, Giovanni wrote:
<br>> Hello,
<br>>  
<br>> I'm proposing we switch infusion's CI tests to use containers and headless browsers:
<br>>  
<br>>     <a href="https://github.com/fluid-project/infusion/pull/909">https://github.com/fluid-project/infusion/pull/909</a>
<br>>  
<br>> I'd like to thank Tony for his work on enabling headless browsers in gpii-testem. It made everything easier while working on this.
<br>>  
<br>> All feedback is welcome!
<br>>  
<br>> Cheers,
<br>> Giovanni
<br>>  
<br>> On 05/30/2018 10:44 AM, Tirloni, Giovanni wrote:
<br>>> With Firefox 60 and Chrome 66, all tests pass in headless mode for fluid-project/infusion.
<br>>>
<br>>>
<br>>>
<br>>> gpii-testem$ git diff src/js/testem-component.js
<br>>>
<br>>> diff --git a/src/js/testem-component.js b/src/js/testem-component.js
<br>>> index 60b0968..416836c 100644
<br>>> --- a/src/js/testem-component.js
<br>>> +++ b/src/js/testem-component.js
<br>>> @@ -429,10 +429,9 @@ fluid.defaults("gpii.testem.base", {
<br>>>             ]
<br>>>         },
<br>>>         "headlessBrowserArgs": {
<br>>> -        // TODO: enable once a new enough version of Firefox is available in CI.
<br>>> -        // "Firefox": [
<br>>> -        //     "--headless"
<br>>> -        // ],
<br>>> +         "Firefox": [
<br>>> +             "--headless"
<br>>> +         ],
<br>>>             // See this ticket for details on the minimum options required to get "headless" Chrome working: <a href="https://github.com/testem/testem/issues/1106#issuecomment-298841383">https://github.com/testem/testem/issues/1106#issuecomment-298841383</a>
<br>>>             "Chrome": [
<br>>>                 "--disable-gpu",
<br>>>
<br>>>
<br>>>
<br>>> If this is all there's to it, we can start migrating CI to headless if people are confident in the new headless features in Chrome/Firefox.
<br>>>
<br>>>
<br>>> On 06/06/2017 11:01 AM, Tirloni, Giovanni wrote:
<br>>>> On 07/11/2016 05:56 AM, Tony Atkins wrote:
<br>>>>> To continue our ongoing discussions around browser testing, I wanted to point out the upcoming release of a "headless" mode for Chromium.
<br>>>>> <a href="https://bugs.chromium.org/p/chromium/issues/detail?id=546953">https://bugs.chromium.org/p/chromium/issues/detail?id=546953</a>
<br>>>>
<br>>>> Hello,
<br>>>>
<br>>>>      I tested Chrome 59 and Firefox 55 Nightly in headless mode [0][1]. Everything worked fine with Chrome (all tests pass).
<br>>>>
<br>>>>      Firefox is not quite there yet (multiple failures in Infusion and OAuth2 fail in GPII/universal).
<br>>>>
<br>>>>      This should greatly simplify our CI setup, once it's ready (no need for Xorg/Xfvb, the browser could be in a container image).
<br>>>>
<br>>>>
<br>>>> 0 - <a href="https://bugzilla.mozilla.org/show_bug.cgi?id=1338004">https://bugzilla.mozilla.org/show_bug.cgi?id=1338004</a>
<br>>>> 1 - <a href="https://www.mozilla.org/en-US/firefox/channel/desktop/">https://www.mozilla.org/en-US/firefox/channel/desktop/</a>
<br>>>>
<br>>>> Regards,
<br>>>> Giovanni
<br>>>>
<br>>>>
<br>>>>
<br>>>> #GPII/universal/tests/web/testem_qi.json:
<br>>>>
<br>>>> {
<br>>>>         "test_page": "tests/web/html/all-tests.html",
<br>>>>         "reporter": "tap",
<br>>>>         "report_file": "report.tap",
<br>>>>         "browser_args": {
<br>>>>            "Chrome": [ "--headless", "--disable-gpu", "--remote-debugging-port=9222" ]
<br>>>>         },
<br>>>>         "launchers": {
<br>>>>             "Firefox Nightly": {
<br>>>>                 "command": "/home/gtirloni/Downloads/firefox-nightly/firefox/firefox --headless <url>",
<br>>>>                 "protocol": "browser"
<br>>>>             }
<br>>>>         }
<br>>>>
<br>>>> }
<br>>>>
<br>>>> # fluid-project/infusion/tests/testem.json
<br>>>>
<br>>>> {
<br>>>>         "test_page": "tests/all-tests.html",
<br>>>>         "timeout": 300,
<br>>>>         "reporter": "tap",
<br>>>>         "report_file": "report.tap",
<br>>>>         "browser_args": {
<br>>>>            "Chrome": [ "--headless", "--disable-gpu", "--remote-debugging-port=9222" ]
<br>>>>         },
<br>>>>         "launchers": {
<br>>>>             "Node Module Basic Packaging Tests": {
<br>>>>                 "command": "node tests/node-tests/basic-node-tests.js --tap",
<br>>>>                 "protocol": "tap"
<br>>>>             },
<br>>>>             "Firefox Nightly": {
<br>>>>                 "command": "/home/gtirloni/Downloads/firefox-nightly/firefox/firefox --headless <url>",
<br>>>>                 "protocol": "browser"
<br>>>>             }
<br>>>>         }
<br>>>> }
<br>>>>
<br>>>>
<br>>>>
<br>>> _______________________________________________________
<br>>> fluid-work mailing list - <a href="mailto:fluid-work@lists.idrc.ocad.ca">fluid-work@lists.idrc.ocad.ca</a>
<br>>> To unsubscribe, change settings or access archives,
<br>>> see <a href="https://lists.idrc.ocad.ca/mailman/listinfo/fluid-work">https://lists.idrc.ocad.ca/mailman/listinfo/fluid-work</a>
<br>>>
<br>> _______________________________________________________
<br>> fluid-work mailing list - <a href="mailto:fluid-work@lists.idrc.ocad.ca">fluid-work@lists.idrc.ocad.ca</a>
<br>> To unsubscribe, change settings or access archives,
<br>> see <a href="https://lists.idrc.ocad.ca/mailman/listinfo/fluid-work">https://lists.idrc.ocad.ca/mailman/listinfo/fluid-work</a>
<br>>  
<br>_______________________________________________________
<br>fluid-work mailing list - <a href="mailto:fluid-work@lists.idrc.ocad.ca">fluid-work@lists.idrc.ocad.ca</a>
<br>To unsubscribe, change settings or access archives,
<br>see <a href="https://lists.idrc.ocad.ca/mailman/listinfo/fluid-work">https://lists.idrc.ocad.ca/mailman/listinfo/fluid-work</a>
<br></div></div></span></blockquote></body></html>