<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">I'll look at this one and FLUID-4537.<div><br></div><div><div>Michelle</div><div><br></div><div><div apple-content-edited="true"><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><br></div></div></span><br class="Apple-interchange-newline"></span><br class="Apple-interchange-newline">
</div>
<br><div><div>On 2011-11-14, at 2:36 PM, Colin Clark wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>Who wants to take on the review of this change?<br><br>Colin<br><br>Begin forwarded message:<br><br><blockquote type="cite">From: Antranig Basman <<a href="mailto:reply+i-2220522-c7d656119e53f33fe07c7202206458cf3ce604b3-558076@reply.github.com">reply+i-2220522-c7d656119e53f33fe07c7202206458cf3ce604b3-558076@reply.github.com</a>><br></blockquote><blockquote type="cite">Subject: [infusion] FLUID-4532: Reverting ARIA labeller component to pre-IoC strategy (#190)<br></blockquote><blockquote type="cite">Date: 13 November, 2011 2:40:33 AM EST<br></blockquote><blockquote type="cite">To: Colin Clark <<a href="mailto:colinbdclark@gmail.com">colinbdclark@gmail.com</a>><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">This implementation should never have been using IoC - this looks like a grievous conceptual error left over from some cleanup after CSpace/1.3 work of late last year. As well as running into the FLUID-4192 "broken trees" issue, this unacceptably exposes users of FluidView.js onto a dependence on the IoC system. It should be possible for anyone to use the aria labeller without including IoC - I have reverted the impl onto an old-fashioned "unicast" event for the time being which will still enable this strategy to be customised as per the apparent original intention. <br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">You can merge this Pull Request by running:<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"> git pull <a href="https://github.com/amb26/infusion">https://github.com/amb26/infusion</a> FLUID-4532<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Or you can view, comment on it, or merge it online at:<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"> <a href="https://github.com/fluid-project/infusion/pull/190">https://github.com/fluid-project/infusion/pull/190</a><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">-- Commit Summary --<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">* FLUID-4532: Reverting ARIA labeller component to pre-IoC strategy<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">-- File Changes --<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">M src/webapp/framework/core/js/FluidView.js (10)<br></blockquote><blockquote type="cite">A src/webapp/tests/component-tests/reorderer/html/AriaLabeller-test.html (72)<br></blockquote><blockquote type="cite">A src/webapp/tests/component-tests/reorderer/js/AriaLabellerTests.js (57)<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">-- Patch Links --<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"> <a href="https://github.com/fluid-project/infusion/pull/190.patch">https://github.com/fluid-project/infusion/pull/190.patch</a><br></blockquote><blockquote type="cite"> <a href="https://github.com/fluid-project/infusion/pull/190.diff">https://github.com/fluid-project/infusion/pull/190.diff</a><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">--- <br></blockquote><blockquote type="cite">Reply to this email directly or view it on GitHub:<br></blockquote><blockquote type="cite"><a href="https://github.com/fluid-project/infusion/pull/190">https://github.com/fluid-project/infusion/pull/190</a><br></blockquote><br>---<br>Colin Clark<br>Technical Lead, Fluid Project<br><a href="http://fluidproject.org">http://fluidproject.org</a><br><br>_______________________________________________________<br>fluid-work mailing list - fluid-work@fluidproject.org<br>To unsubscribe, change settings or access archives,<br>see http://lists.idrc.ocad.ca/mailman/listinfo/fluid-work<br></div></blockquote></div><br></div></div></body></html>