Regarding the project "Port UIO+ Chrome Extension to Firefox and Safari"

Justin Obara obara.justin at gmail.com
Mon Mar 30 14:40:26 UTC 2020


Hi Umang,

You will need to have tests for the extension. One of the goals of the project is to share as much of the code base as possible across the various extensions.

Thanks
Justin

> On Mar 30, 2020, at 9:21 AM, Umang Modi <umangkumarmodi at gmail.com> wrote:
> 
> Hello Justin,
> 
> Thanks for the reply. I'll definately do that and just wanted to clarify that do I have to write the tests for Firefox separately as all the given test files for Chrome is running fine for Firefox browser as well. Please reply soon :)
> 
> Thanks
> Umang
> 
> On Mon, Mar 30, 2020, 6:19 PM Justin Obara <obara.justin at gmail.com <mailto:obara.justin at gmail.com>> wrote:
> Hello Umang,
> 
> You should make sure that the porting of the extension to other browsers will be easily maintainable as new features and bug fixes are added. Also don’t forget to add time for implementing new adaptions to use in the extension.
> 
> Thanks
> Justin
> 
>> On Mar 28, 2020, at 5:15 PM, Umang Modi <umangkumarmodi at gmail.com <mailto:umangkumarmodi at gmail.com>> wrote:
>> 
>> Hi Justin,
>> 
>> I am already halfway through the proposal but have a doubt. 
>> 
>> As I'm seeing in the repository, to port the extension there will be very less changes in the codebase and almost all the documentation will be same except for some API code configurations & handling errors while testing and debugging. So, I assume this will not take much time as most of the task will include copying and pasting the code.
>> 
>> So just wanted to know if I should set up the entire CI configurations or just port the extension by the above process?
>> 
>> Regards,
>> Umang Modi
>> 
>> On Thu, Mar 26, 2020, 9:16 PM Justin Obara <obara.justin at gmail.com <mailto:obara.justin at gmail.com>> wrote:
>> You should just update your existing PR.
>> 
>>> On Mar 26, 2020, at 11:39 AM, Umang Modi <umangkumarmodi at gmail.com <mailto:umangkumarmodi at gmail.com>> wrote:
>>> 
>>> I'm really really sorry for this. Shall I make a PR again to the project's repo?
>>> 
>>> Thanks,
>>> Umang
>>> 
>>> On Thu, Mar 26, 2020, 9:01 PM Justin Obara <obara.justin at gmail.com <mailto:obara.justin at gmail.com>> wrote:
>>> It looks like you’ve made those PRs against your own repo. You need to make the PR against the project’s repo. Also, you shouldn’t make new PRs for each commit. Those should all be done in the same branch and submitted under a single PR. If the code changes are not related, then they should be filed under a separate issue and separate PR.
>>> 
>>> Thanks
>>> Justin
>>> 
>>>> On Mar 26, 2020, at 11:19 AM, Umang Modi <umangkumarmodi at gmail.com <mailto:umangkumarmodi at gmail.com>> wrote:
>>>> 
>>>> No, I've updated the previous code and again made a PR today.
>>>> 
>>>> For manifest.json :
>>>> https://github.com/modiumang28/gpii-chrome-extension/pull/1 <https://github.com/modiumang28/gpii-chrome-extension/pull/1>
>>>> 
>>>> For background.js :
>>>> https://github.com/modiumang28/gpii-chrome-extension/pull/2 <https://github.com/modiumang28/gpii-chrome-extension/pull/2>
>>>> 
>>>> On Thu, Mar 26, 2020, 8:42 PM Justin Obara <obara.justin at gmail.com <mailto:obara.justin at gmail.com>> wrote:
>>>> I assume you mean https://github.com/GPII/gpii-chrome-extension/pull/49 <https://github.com/GPII/gpii-chrome-extension/pull/49>. I reviewed it 2 days ago and don’t see any code changes since.
>>>> 
>>>> Thanks
>>>> Justin
>>>> 
>>>>> On Mar 26, 2020, at 9:59 AM, Umang Modi <umangkumarmodi at gmail.com <mailto:umangkumarmodi at gmail.com>> wrote:
>>>>> 
>>>>> Hi Justin,
>>>>> 
>>>>> I have send a PR for the GPII-4241 issue. Can you please check if it's correct or not?
>>>>> 
>>>>> Thanks, 
>>>>> Umang Modi
>>>>> 
>>>>> On Wed, Mar 25, 2020, 5:28 PM Justin Obara <obara.justin at gmail.com <mailto:obara.justin at gmail.com>> wrote:
>>>>> Hi Umang,
>>>>> 
>>>>> Please don’t include screen shots of code, please include either a link to the code in your GitHub repo, gist, pastebin, etc or include the code directly in the e-mail. 
>>>>> 
>>>>>> "Also the issue (GPII-4241 <https://issues.gpii.net/browse/GPII-4241>) suggested a keyboard shortcut. While the suggested one won't work, you can look into creating something similar based off of it."
>>>>>> Can you please elaborate on what context you're saying it would not work?
>>>>>> Is it like all the keyboard shortcuts should be same for all machines or is it something else?
>>>>> 
>>>>> In the issue GPII-4241 <https://issues.gpii.net/browse/GPII-4241> it suggests using "shift-ctrl-opt-win-u” as the keyboard shortcut. However, the chrome.commands <https://developer.chrome.com/apps/commands> API prohibits prohibits mixing Ctrl+Alt (in the suggested keyboard shortcut opt is the same as alt).
>>>>> 
>>>>>> - Also whenever I'm loading the unpacked extension on Google Chrome I'm getting an error message "WebSocket connection to 'ws://localhost:8081/browserChannel <>' failed: Error in connection establishment: net::ERR_CONNECTION_REFUSED". I am including the image of the error message below. Please help me fix this error.
>>>>> 
>>>>> 
>>>>> That’s because it’s trying to connect to Morphic <https://morphic.world/>  but you do not have Morphic running on your machine. Don’t worry about that error for now though, it just means that preferences from Morphic won’t be passed into the extension.
>>>>> 
>>>>> Thanks
>>>>> Justin
>>>>> 
>>>>>> On Mar 24, 2020, at 5:16 PM, Umang Modi <umangkumarmodi at gmail.com <mailto:umangkumarmodi at gmail.com>> wrote:
>>>>>> 
>>>>>> Hi Justin, 
>>>>>> 
>>>>>> I cloned the entire repo and built the extension locally on my computer. Currently, I'm using Windows 10 OS, and after loading the unpacked extension on Google Chrome I tried using the keyboard shortcut to open the extension panel and I didn't face any issue. 
>>>>>> "Also the issue (GPII-4241 <https://issues.gpii.net/browse/GPII-4241>) suggested a keyboard shortcut. While the suggested one won't work, you can look into creating something similar based off of it."
>>>>>> Can you please elaborate on what context you're saying it would not work?
>>>>>> Is it like all the keyboard shortcuts should be same for all machines or is it something else?
>>>>>> I'm including an image of the code. Please check if the bug if fixed or not.
>>>>>> 
>>>>>> - Also whenever I'm loading the unpacked extension on Google Chrome I'm getting an error message "WebSocket connection to 'ws://localhost:8081/browserChannel <>' failed: Error in connection establishment: net::ERR_CONNECTION_REFUSED". I am including the image of the error message below. Please help me fix this error.
>>>>>> 
>>>>>> Thanks and Regards,
>>>>>> Umang Modi
>>>>>> 
>>>>>> 
>>>>>> On Tue, Mar 24, 2020 at 9:04 PM Justin Obara <obara.justin at gmail.com <mailto:obara.justin at gmail.com>> wrote:
>>>>>> Hello Umang,
>>>>>> 
>>>>>> Thanks for the PR <https://github.com/GPII/gpii-chrome-extension/pull/49>. I’ve left a review on it.
>>>>>> 
>>>>>> Thanks
>>>>>> Justin
>>>>>> 
>>>>>>> On Mar 24, 2020, at 11:13 AM, Umang Modi <umangkumarmodi at gmail.com <mailto:umangkumarmodi at gmail.com>> wrote:
>>>>>>> 
>>>>>>> Hi Justin,
>>>>>>> 
>>>>>>> I have tried to fix the error in JIRA issue GPII-4241, and created a pull request. Can you please check if the bug has been fixed or not?
>>>>>>> 
>>>>>>> Thanks!
>>>>>>> Umang Modi
>>>>>>> 
>>>>>>> On Tue, Mar 24, 2020 at 12:27 AM Justin Obara <obara.justin at gmail.com <mailto:obara.justin at gmail.com>> wrote:
>>>>>>> Hi Umang,
>>>>>>> 
>>>>>>> Some comments inline below.
>>>>>>> 
>>>>>>> Thanks
>>>>>>> Justin
>>>>>>> 
>>>>>>>> On Mar 23, 2020, at 2:45 PM, Umang Modi <umangkumarmodi at gmail.com <mailto:umangkumarmodi at gmail.com>> wrote:
>>>>>>>> 
>>>>>>>> Hi Justin, 
>>>>>>>> 
>>>>>>>> Thanks for your reply. However, I have a few more doubts. I'm listing them down here:
>>>>>>>> 1. Could you please tell me about the development environment you've used while building the current version of the project as It'll help me understand all the files better.
>>>>>>> 
>>>>>>> Not really sure what you’re looking for here. You can follow the “Building the extension <https://github.com/GPII/gpii-chrome-extension#building-the-extension>” section of the README to get started. 
>>>>>>> 
>>>>>>>> 2. In the .editorconfig <https://github.com/GPII/gpii-chrome-extension/blob/master/.editorconfig> file you have specified all the configurations for the editor, so do we have to follow that strictly or we can change that according to our own preferences? Please also tell me about the editor you used.
>>>>>>> 
>>>>>>> You can use whichever editor you like, but you must adhere to the coding style.
>>>>>>> 
>>>>>>>> 3. I'm not able to understand the contents of .eslintignore <https://github.com/GPII/gpii-chrome-extension/blob/master/.eslintignore> file and for what it is used?
>>>>>>>> 4. I think .eslintrc.json <https://github.com/GPII/gpii-chrome-extension/blob/master/.eslintrc.json> file is corresponding to the configuration that we have to include when setting up ESLint, so do we have to strictly abide by that or can we explore additional configuration and then later add it in the.eslintrc.json <https://github.com/GPII/gpii-chrome-extension/blob/master/.eslintrc.json>  file?
>>>>>>> 
>>>>>>> You should look up https://eslint.org <https://eslint.org/> and as mentioned above you must adhere to the coding style. You can propose changes to the coding style if you like, but adoption will affect everyone working on the project. 
>>>>>>> 
>>>>>>>> 5. In the .gitignore <https://github.com/GPII/gpii-chrome-extension/blob/master/.gitignore> file, It's suggesting to ignore .nyc_output folder, so is this the same folder that corresponds to the .nycrc file in the root directory?
>>>>>>> 
>>>>>>> Yes, those are related to output of reports from the testing. 
>>>>>>> 
>>>>>>>> 
>>>>>>>> I would be really thankful if you could find time to answer this.
>>>>>>>> 
>>>>>>>> Regards,
>>>>>>>> Umang Modi 
>>>>>>>> 
>>>>>>>> On Wed, Mar 18, 2020 at 10:39 PM Justin Obara <obara.justin at gmail.com <mailto:obara.justin at gmail.com>> wrote:
>>>>>>>> Hi Umang,
>>>>>>>> 
>>>>>>>> I suppose it’s fine to build using a VM; however, unless you have a VM in a supported cloud environment I’m not sure you’ll be able to run one. The last I checked, macOS only allowed virtualized macOS instances to run on Apple hardware. If it isn’t something you can do, and you still want to work on this project make sure to mention that as part of your proposal and ensure that the scope and breadth of your work is sufficient for the time.
>>>>>>>> 
>>>>>>>> Thanks
>>>>>>>> Justin
>>>>>>>> 
>>>>>>>> > On Mar 18, 2020, at 11:46 AM, Umang Modi <umangkumarmodi at gmail.com <mailto:umangkumarmodi at gmail.com>> wrote:
>>>>>>>> > 
>>>>>>>> > Hi everyone,
>>>>>>>> > 
>>>>>>>> > I am Umang Modi, and I would like to contribute in the project "Port UIO+ Chrome Extension to Firefox and Safari" but I have some questions regarding it and need your help for the same.
>>>>>>>> > 
>>>>>>>> > As in the project description it is written we have to make and add an extension that will work in both the Firefox and Safari extensions.
>>>>>>>> > To develop an extension for Safari browser we need Xcode development enviroment which is only build for macOS and I don't have access to mac operating system.
>>>>>>>> > 
>>>>>>>> > 1.Currently I'm using Windows operating system so can we use virtual machine to develop extension for safari browsers?
>>>>>>>> > 2. Will there be any compatibility issues or will there be any issue in the efficiency of the extension build through virtual machine for safari browsers?
>>>>>>>> > 
>>>>>>>> > Thanks and Regards,
>>>>>>>> > Umang Modi
>>>>>>>> > Birla Institute of Technology, Mesra
>>>>>>>> > 
>>>>>>>> > 
>>>>>>>> > 
>>>>>>>> > 
>>>>>>>> > 
>>>>>>>> > 
>>>>>>>> > _______________________________________________________
>>>>>>>> > fluid-work mailing list - fluid-work at lists.idrc.ocad.ca <mailto:fluid-work at lists.idrc.ocad.ca>
>>>>>>>> > To unsubscribe, change settings or access archives,
>>>>>>>> > see https://lists.idrc.ocad.ca/mailman/listinfo/fluid-work <https://lists.idrc.ocad.ca/mailman/listinfo/fluid-work>
>>>>>>>> 
>>>>>>>> _______________________________________________________
>>>>>>>> fluid-work mailing list - fluid-work at lists.idrc.ocad.ca <mailto:fluid-work at lists.idrc.ocad.ca>
>>>>>>>> To unsubscribe, change settings or access archives,
>>>>>>>> see https://lists.idrc.ocad.ca/mailman/listinfo/fluid-work <https://lists.idrc.ocad.ca/mailman/listinfo/fluid-work>
>>>>>> 
>>>>>> <Manifest file Image.jpeg><Error Message.jpeg>
>>>>> 
>>>> 
>>> 
>> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.idrc.ocad.ca/pipermail/fluid-work/attachments/20200330/f7e09cf7/attachment.html>


More information about the fluid-work mailing list