Regarding the project "Port UIO+ Chrome Extension to Firefox and Safari"

Justin Obara obara.justin at gmail.com
Tue Mar 24 15:34:01 UTC 2020


Hello Umang,

Thanks for the PR <https://github.com/GPII/gpii-chrome-extension/pull/49>. I’ve left a review on it.

Thanks
Justin

> On Mar 24, 2020, at 11:13 AM, Umang Modi <umangkumarmodi at gmail.com> wrote:
> 
> Hi Justin,
> 
> I have tried to fix the error in JIRA issue GPII-4241, and created a pull request. Can you please check if the bug has been fixed or not?
> 
> Thanks!
> Umang Modi
> 
> On Tue, Mar 24, 2020 at 12:27 AM Justin Obara <obara.justin at gmail.com <mailto:obara.justin at gmail.com>> wrote:
> Hi Umang,
> 
> Some comments inline below.
> 
> Thanks
> Justin
> 
>> On Mar 23, 2020, at 2:45 PM, Umang Modi <umangkumarmodi at gmail.com <mailto:umangkumarmodi at gmail.com>> wrote:
>> 
>> Hi Justin, 
>> 
>> Thanks for your reply. However, I have a few more doubts. I'm listing them down here:
>> 1. Could you please tell me about the development environment you've used while building the current version of the project as It'll help me understand all the files better.
> 
> Not really sure what you’re looking for here. You can follow the “Building the extension <https://github.com/GPII/gpii-chrome-extension#building-the-extension>” section of the README to get started. 
> 
>> 2. In the .editorconfig <https://github.com/GPII/gpii-chrome-extension/blob/master/.editorconfig> file you have specified all the configurations for the editor, so do we have to follow that strictly or we can change that according to our own preferences? Please also tell me about the editor you used.
> 
> You can use whichever editor you like, but you must adhere to the coding style.
> 
>> 3. I'm not able to understand the contents of .eslintignore <https://github.com/GPII/gpii-chrome-extension/blob/master/.eslintignore> file and for what it is used?
>> 4. I think .eslintrc.json <https://github.com/GPII/gpii-chrome-extension/blob/master/.eslintrc.json> file is corresponding to the configuration that we have to include when setting up ESLint, so do we have to strictly abide by that or can we explore additional configuration and then later add it in the .eslintrc.json <https://github.com/GPII/gpii-chrome-extension/blob/master/.eslintrc.json>  file?
> 
> You should look up https://eslint.org <https://eslint.org/> and as mentioned above you must adhere to the coding style. You can propose changes to the coding style if you like, but adoption will affect everyone working on the project. 
> 
>> 5. In the .gitignore <https://github.com/GPII/gpii-chrome-extension/blob/master/.gitignore> file, It's suggesting to ignore .nyc_output folder, so is this the same folder that corresponds to the .nycrc file in the root directory?
> 
> Yes, those are related to output of reports from the testing. 
> 
>> 
>> I would be really thankful if you could find time to answer this.
>> 
>> Regards,
>> Umang Modi 
>> 
>> On Wed, Mar 18, 2020 at 10:39 PM Justin Obara <obara.justin at gmail.com <mailto:obara.justin at gmail.com>> wrote:
>> Hi Umang,
>> 
>> I suppose it’s fine to build using a VM; however, unless you have a VM in a supported cloud environment I’m not sure you’ll be able to run one. The last I checked, macOS only allowed virtualized macOS instances to run on Apple hardware. If it isn’t something you can do, and you still want to work on this project make sure to mention that as part of your proposal and ensure that the scope and breadth of your work is sufficient for the time.
>> 
>> Thanks
>> Justin
>> 
>> > On Mar 18, 2020, at 11:46 AM, Umang Modi <umangkumarmodi at gmail.com <mailto:umangkumarmodi at gmail.com>> wrote:
>> > 
>> > Hi everyone,
>> > 
>> > I am Umang Modi, and I would like to contribute in the project "Port UIO+ Chrome Extension to Firefox and Safari" but I have some questions regarding it and need your help for the same.
>> > 
>> > As in the project description it is written we have to make and add an extension that will work in both the Firefox and Safari extensions.
>> > To develop an extension for Safari browser we need Xcode development enviroment which is only build for macOS and I don't have access to mac operating system.
>> > 
>> > 1.Currently I'm using Windows operating system so can we use virtual machine to develop extension for safari browsers?
>> > 2. Will there be any compatibility issues or will there be any issue in the efficiency of the extension build through virtual machine for safari browsers?
>> > 
>> > Thanks and Regards,
>> > Umang Modi
>> > Birla Institute of Technology, Mesra
>> > 
>> > 
>> > 
>> > 
>> > 
>> > 
>> > _______________________________________________________
>> > fluid-work mailing list - fluid-work at lists.idrc.ocad.ca <mailto:fluid-work at lists.idrc.ocad.ca>
>> > To unsubscribe, change settings or access archives,
>> > see https://lists.idrc.ocad.ca/mailman/listinfo/fluid-work <https://lists.idrc.ocad.ca/mailman/listinfo/fluid-work>
>> 
>> _______________________________________________________
>> fluid-work mailing list - fluid-work at lists.idrc.ocad.ca <mailto:fluid-work at lists.idrc.ocad.ca>
>> To unsubscribe, change settings or access archives,
>> see https://lists.idrc.ocad.ca/mailman/listinfo/fluid-work <https://lists.idrc.ocad.ca/mailman/listinfo/fluid-work>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.idrc.ocad.ca/pipermail/fluid-work/attachments/20200324/2a4ffaf6/attachment.html>


More information about the fluid-work mailing list