[Failed] Fluid Project / Fluid Infusion #237 (jobara:FLUID-6281)
gtirloni at ocadu.ca
Tue May 22 15:01:16 UTC 2018
On 05/22/2018 11:35 AM, Justin Obara wrote:
> Hi Gio,
> I merged in the PR ( https://github.com/fluid-project/infusion/pull/901 ). Is it possible/secure to document these agents somewhere?
Thank you! Right now the implementation of the agents is changing quite a bit in the background (specially as I try to fit the 'continuous deployment' steps into our CI/CD pipeline). It's requiring some changes to how we deploy the code (going from traditional config management to Docker containers to Kubernetes deployments). Fortunately this will all make CI rather easy in the future, if necessary, because the deployment logic is not tied to specific Jenkins plugins (or Buildkite plugins for that matter).
Avtar has added some documentation in the page below and I'll be extending that shortly:
> Regarding GitHub’s code owners, I don’t recall talking about it before. I don’t think it’s a bad idea; however, I’m not immediately sure how to be partition the code base. I suppose we should ping the entire Maintainers team by default and maybe refine the list in a few specific areas. I’m open to suggestions on this.
Agreed. I don't know about the rest of the code base but I was thinking defining ownership of the .buildkite directory (and maybe the Vagrantfile/Dockerfile) to the Ops team might alleviate the Review burden on the Maintainers team.
> Also we may want to explore protected branches. For example ensuring that the checks all pass and that code review is done before a merge can happen seems reasonable for the Master and all the release branches (e.g. infusion-1.5.x). I feel like there was a potential issue with protected branches and buildkite. Do you know if that’s still a problem?
I think this would be great. The issue with Buildkite and Protected Branches was more of a guess from the BK Support Team as to what was causing the PR's statuses not to get updated when a build finished. Since they moved us to their (internal) PR updater, it seems the issue is gone. I'd say things should work with protected branches in general.
More information about the fluid-work