[Failed] Fluid Project / Fluid Infusion #237 (jobara:FLUID-6281)

Justin Obara obara.justin at gmail.com
Tue May 22 14:34:57 UTC 2018


Hi Gio,

I merged in the PR ( https://github.com/fluid-project/infusion/pull/901 ).
Is it possible/secure to document these agents somewhere?

Regarding GitHub’s code owners, I don’t recall talking about it before. I
don’t think it’s a bad idea; however, I’m not immediately sure how to be
partition the code base. I suppose we should ping the entire Maintainers
team by default and maybe refine the list in a few specific areas. I’m open
to suggestions on this.

Also we may want to explore protected branches. For example ensuring that
the checks all pass and that code review is done before a merge can happen
seems reasonable for the Master and all the release branches (e.g.
infusion-1.5.x). I feel like there was a potential issue with protected
branches and buildkite. Do you know if that’s still a problem?

Thanks
Justin


On May 17, 2018 at 6:22:19 PM, Tirloni, Giovanni (gtirloni at ocadu.ca) wrote:

Hi Justin,

This job failed because it was directed at the i-0033 server (which is a
new Docker host in Buildkite that we're using for SJRK). It should have
gone to the h-0005, which is the usual CI build node.

This is because the original Infusion pipeline doesn't specify any "agent
tags". This is what this PR is for:
https://github.com/fluid-project/infusion/pull/901/files

As we expand the number of agents, the pipelines will need to be more
specific about where they want to run.

I've tested this PR with a few builds and it seems okay. The only failure
was caused by a transient issue with `npm install`:
https://buildkite.com/fluid-project/fluid-infusion/builds?branch=gtirloni-fluid%3AINFRA-162-target-vagrant

Finally, PR's for the .buildkite directory might be more frequent as we
increase our understanding of Buildkite. Maybe we could adopt GitHub's
owners for it? I don't know if this was discussed already for the project
but it looks like a good idea to me (
https://blog.github.com/2017-07-06-introducing-code-owners/).

I know you're busy with imminent awesome news so I'm sending this to
fluid-work@ in case you can't look at it and someone else wants to :)

Regards,
Giovanni

On 05/17/2018 05:41 PM, Buildkite wrote:
> FLUID-6281: Adding test case to verify issue. <
https://buildkite.com/fluid-project/fluid-infusion/builds/237> Duration: 9
minutes, 1 second
> Build #237 <https://buildkite.com/fluid-project/fluid-infusion/builds/237>
| jobara:FLUID-6281 | fbc717b <
https://github.com/fluid-project/infusion/commit/fbc717b051f3635b3b451da9f79f175724b7dba1>
(Pull Request #902 <https://github.com/fluid-project/infusion/pull/902>)
>
> jobara View Build → <
https://buildkite.com/fluid-project/fluid-infusion/builds/237>
>
> Sent by *Buildkite <https://helpscout.buildkite.com/>* Manage Email
Preferences <https://buildkite.com/user/emails>
>
_______________________________________________________
fluid-work mailing list - fluid-work at lists.idrc.ocad.ca
To unsubscribe, change settings or access archives,
see https://lists.idrc.ocad.ca/mailman/listinfo/fluid-work
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.idrc.ocad.ca/pipermail/fluid-work/attachments/20180522/81590462/attachment.html>


More information about the fluid-work mailing list