Deforked versions of framework and video player ready for review (FLUID-4607, FLUID-4531)

Justin Obara obara.justin at gmail.com
Thu Mar 29 11:30:56 UTC 2012


Hi Antranig, 

I believe what you are talking about are the UIO specific variants of the fss-themes. These are generated during a build and add !importants to certain tags, to help UIO win out. You can see this in more detail in the StylesheetImportant.js file.
https://github.com/fluid-project/infusion/blob/master/build-scripts/uiOptions/js/StylesheetImportant.js

As for why it would be appearing and disappearing, I guess you had run a build and accidentally committed them in one of your branches.

Hope that helps
Justin

On 2012-03-29, at 3:03 AM, Antranig Basman wrote:

> I have just issued
> 
> https://github.com/fluid-project/videoPlayer/pull/28
> and
> https://github.com/fluid-project/infusion/pull/216
> 
> which are a matched set of pull requests for the core framework and the video player - this finally restores the Infusion build used by the player to a plausible core framework with all of the media panel-specific materials which were inserted into UIOptions pulled back out into the videoPlayer component. This puts us halfway on the path towards "ants" - we at least now have the ability to customise panels in UIO without touching the core framework, although right now in a slightly clunky way that requires some duplicated material left behind in Store.js as well as some "pointy configuration". Still, it is better than a poke in the eye. No jokes about a poke in the eye from some pointy configuration.
> 
> I noticed an oddity in UIOptions itself, in that there is some material in uiOptions/css/fss that seems to keep appearing and disappearing depending on what branch I am on... I haven't been able to track down exactly how it appeared or disappeared, but it is not present in the current core framework, although since a reference remains to it in the core framework's FatPanelUIOptionsFrame.html file I have reinserted it for now. Could someone who knows about these things let me know if it shouldn't be there, and I'll remove it as well as the references to it.
> 
> Cheers,
> Antranig
> _______________________________________________________
> fluid-work mailing list - fluid-work at fluidproject.org
> To unsubscribe, change settings or access archives,
> see http://lists.idrc.ocad.ca/mailman/listinfo/fluid-work



More information about the fluid-work mailing list