Getting the video player demo branch into master

Colin Clark colinbdclark at gmail.com
Wed Mar 7 19:45:28 UTC 2012


Hi Michelle,

Thanks for the thorough list. Comments inline...

On 2012-03-07, at 11:30 AM, Michelle D'Souza wrote:
> 	* We did some hacking of the framework and added an additional framework file for the video player. I think we should have a branch in the Infusion repo from where we can build a new MyInfusion for the video player and this should be documented in the Readme file in the lib/infusion directory. Eventually, the framework supports that we require should move into Infusion. 

I imagine this Infusion work (the ability to dynamically modify the settings of a component based on actions in another component) will take a bit of time to bake. A branch in the Infusion repository in the interim makes a lot of sense to me.

> 	* We should look into the reference to FLUID-4606 in MenuButton - it looks like we are doing a hack for a bug that no longer exists. 

What's the nature of the hack? FLUID-4606 seems like a legitimate issue even if it doesn't have any impact on the Video Player itself.

> 	* We should create tests for transcripts.
> 	* We should create tests for menu button.
> 	* We should create tests for toggle button.
> 	* We should create video player integration tests.

Yes!

Colin

---
Colin Clark
Technical Lead, Fluid Project
http://fluidproject.org



More information about the fluid-work mailing list