InlineEdit API change?

Cheetham, Anastasia acheetham at ocadu.ca
Tue Jul 17 14:23:30 UTC 2012


Antranig, thanks for your comments on the API change.

On 2012-07-16, at 5:44 PM, Antranig Basman wrote:

> A good move here would be to write some code to actually copy these options into the strings block after initialisation, and to rewrite the InlineEdit implementation so that the versions in the strings block are the ones used throughout.

This is, in fact, exactly what I have already done.

> You can then supply the signature to bindHighlightHandler as (element, displayModeRenderer, styles, strings) which I think would be a reasonable and communicative signature.

Unfortunately, bindHighlightHandler() also needs to check the model to find out whether or not the field contains text that the user has input (i.e. whether or not to display invitation text at all). This requirement did not exist previously.

You can see the implementation in my branch:
    https://github.com/acheetham/infusion/blob/FLUID-4725/src/webapp/components/inlineEdit/js/InlineEdit.js#L654

I was worried that adding the model as well as the strings to the signature would make it a bit unwieldy:

    bindHighlightHandler (element, displayModeRenderer, styles, strings, model)

but perhaps it is a lesser evil than the "that-ist leak"...

-- 
Anastasia Cheetham     Inclusive Design Research Centre
acheetham at ocadu.ca           Inclusive Design Institute
                                        OCAD University

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 495 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.idrc.ocad.ca/pipermail/fluid-work/attachments/20120717/14515b9d/attachment.pgp>


More information about the fluid-work mailing list