InlineEdit API change?

[Cheetham, Anastasia]

I'm working on implementing a change to InlineEdit requested by the designers: the ability to change the invitation text when focus lands on the field.

	http://issues.fluidproject.org/browse/FLUID-4725

The implementation requires a small API change to one of the functions, fluid.inlineEdit.bindHighlightHandler(), changing the last parameter:

-    fluid.inlineEdit.bindHighlightHandler = function (element, displayModeRenderer, styles) {
+    fluid.inlineEdit.bindHighlightHandler = function (element, displayModeRenderer, that) {

This function binds keyboard focus and blur event handlers to an element. It is not part of the 'public' API, and I suspect that it's not something that is being overridden by implementations: the function basically adds and removes classes, so customization would likely occur by adjusting the styles themselves or overriding the classnames.

I'm wondering how the community feels about this API change. Does anyone want to point out reasons not to make the change?

-- 
Anastasia Cheetham     Inclusive Design Research Centre
acheetham at ocadu.ca           Inclusive Design Institute
                                        OCAD University

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 495 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <https://lists.idrc.ocad.ca/pipermail/fluid-work/attachments/20120716/ac721354/attachment.sig>