Fwd: [infusion] FLUID-4532: Reverting ARIA labeller component to pre-IoC strategy (#190)

Colin Clark colinbdclark at gmail.com
Mon Nov 14 19:36:39 UTC 2011

Who wants to take on the review of this change?


Begin forwarded message:

> From: Antranig Basman <reply+i-2220522-c7d656119e53f33fe07c7202206458cf3ce604b3-558076 at reply.github.com>
> Subject: [infusion] FLUID-4532: Reverting ARIA labeller component to pre-IoC strategy (#190)
> Date: 13 November, 2011 2:40:33 AM EST
> To: Colin Clark <colinbdclark at gmail.com>
> This implementation should never have been using IoC - this looks like a grievous conceptual error left over from some cleanup after CSpace/1.3 work of late last year. As well as running into the FLUID-4192 "broken trees" issue, this unacceptably exposes users of FluidView.js onto a dependence on the IoC system. It should be possible for anyone to use the aria labeller without including IoC - I have reverted the impl onto an old-fashioned "unicast" event for the time being which will still enable this strategy to be customised as per the apparent original intention. 
> You can merge this Pull Request by running:
>  git pull https://github.com/amb26/infusion FLUID-4532
> Or you can view, comment on it, or merge it online at:
>  https://github.com/fluid-project/infusion/pull/190
> -- Commit Summary --
> * FLUID-4532: Reverting ARIA labeller component to pre-IoC strategy
> -- File Changes --
> M src/webapp/framework/core/js/FluidView.js (10)
> A src/webapp/tests/component-tests/reorderer/html/AriaLabeller-test.html (72)
> A src/webapp/tests/component-tests/reorderer/js/AriaLabellerTests.js (57)
> -- Patch Links --
>  https://github.com/fluid-project/infusion/pull/190.patch
>  https://github.com/fluid-project/infusion/pull/190.diff
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/fluid-project/infusion/pull/190

Colin Clark
Technical Lead, Fluid Project

More information about the fluid-work mailing list