Crikey, it's a pull request! (was Re: Pull requests and review on every merge to master)

Colin Clark colinbdclark at
Mon Nov 14 19:32:08 UTC 2011

Hi all,

On the subject of review-before-push, I find myself curiously quiet. 

I am interested in the idea that, as Justin points out, this new proposal might serve as a bit of an equalizer. Regardless of being a contributor or a formal committer, we all go through the same general workflow. Code in a personal repository, make a pull request for inclusion into the project repository, and get reviewed by a peer. At the same time, I also see the argument about resources. Can we scale the review process to a point where it can be done in a timely manner for each new change to Infusion? 

Any reason not to just try it and find out?

On 2011-11-13, at 1:27 AM, Antranig Basman wrote:

> That said, I am extremely excited for us to move to the 100% review model, assuming we can actually make it work economically - in the interests of testing this out, I am putting this FLUID-4525 branch up for pull + review in order to see what happens to it :)

I'll take this review task on. It looks like a worthwhile set of changes.


Colin Clark
Technical Lead, Fluid Project

More information about the fluid-work mailing list