UIOptions code review review - FLUID-4171

Justin Obara obara.justin at gmail.com
Mon May 16 14:11:36 UTC 2011


I think I'm not fully understanding how this all will work. If I remember correctly UI Enhancer was the component that  actually handled modifying the styles on the page. From this thread it sounds like the subcomponents will be doing this now. If that's the case, then won't we need a UI Options on every page and not just a UI Enhancer? I'm not sure how that would work for the full page version. 

I'm pretty sure I'm missing something here. 


On 2011-05-13, at 6:11 PM, Clark, Colin wrote:

> If I'm understanding it correctly, there's an interesting quality to this bundling together of all the behaviour related to a given option. The subcomponent configuration for both UI Options and UI Enhancer is identical, and can be shared. It contains all the information required to setup components for editing the options as well as components for actually executing the option.
> Thanks so much for the summary. This is going to be an awesome refactoring for our flagship component.
> Colin
> On 2011-05-13, at 5:36 PM, Michelle D'Souza wrote:
>> To accomplish this UI Options will be changed to have a subcomponent for every setting. These subcomponents will be composed of everything relating to a particular setting including: a selector, a proto-tree, a model and the strategy for transforming the page based on the setting state. Concretely, this will require building many small components that can be composed into these settings. We will create renderer components for each way a setting can be set - for example a range, a boolean or a select. We would also create small components for each transformation strategy.
>> UI Options itself will become a shell containing subcomponents that are a composition of a renderer component and a transformation strategy. All UI Options would do is compose proto-trees from the subcomponents and render the UI. Eventually, even this work will be in the framework and UI Options will do nothing but hold settings. Similarly, UI Enhancer would defer to these subcomponents when transforming the page. The only real work that would be left in UI Enhancer is any global clean up that needs to be done before performing the transformation. 
> ---
> Colin Clark
> Lead Software Architect,
> Inclusive Design Research Centre, OCAD University
> http://inclusivedesign.ca
> _______________________________________________________
> fluid-work mailing list - fluid-work at fluidproject.org
> To unsubscribe, change settings or access archives,
> see http://fluidproject.org/mailman/listinfo/fluid-work

More information about the fluid-work mailing list