issues with globals in Infusion

Justin Obara obara.justin at gmail.com
Thu Mar 10 18:36:42 UTC 2011


I've filed some jiras, see below.

- Justin
On 2011-03-04, at 11:32 AM, Justin Obara wrote:

> I've been trying to update the globals comment at the top of our js files. This is used to instruct jslint on how to deal with globals that we explicitly define.
> 
> I've come across several issues in the files, which are listed below. I'm planning on filing jiras for these items, but wanted to double check that there weren't special reasons for them.
> 
> Thanks
> Justin
> 
> FluidIoC.js
> ----------------
> 
> not sure where "segs" on line 70 comes from
> 
> 
> ImageReordererTestConstants.js
> ---------------------------------------------
> 
> This file contains nothing but global functions, should we namespace them.
> 

http://issues.fluidproject.org/browse/FLUID-4136

> 
> UnorderedListConstants.js
> ---------------------------------------------
> 
> This file contains nothing but global functions, should we namespace them.

http://issues.fluidproject.org/browse/FLUID-4136

> 
> 
> CachingTests.js
> -----------------------
> 
> Uses the stop() function. Maybe these should be converted to asyncTests

http://issues.fluidproject.org/browse/FLUID-4137

> 
> 
> FluidViewTests.js
> -----------------------
> 
> Uses the stop() function. Maybe these should be converted to asyncTests

http://issues.fluidproject.org/browse/FLUID-4137

> 
> 
> keyboard-a11y-tests.js
> --------------------------------
> 
> - File name starts with a lower case k, which doesn't follow convention.

http://issues.fluidproject.org/browse/FLUID-4138

> - uses an "ok" function call even though jqunit is being used throughout

http://issues.fluidproject.org/browse/FLUID-4139
> 
> 
> TestUtils.js
> --------------- 
> 
> uses both jQuery and $ without a closure




More information about the fluid-work mailing list