fluid.stringTemplate and multiple replacement

charly molter charly.molter at gmail.com
Wed Jul 27 20:26:01 UTC 2011


Hello,
Don't worry I'll take care of it I only got the tests to write but
they are currently clear in my mind. Did they were already a series of
test for the stringTemplate? Also How should I give them? is there a
specific place to put them?

Thank you
Charly

On Wed, Jul 27, 2011 at 8:42 PM, Antranig Basman
<antranig.basman at colorado.edu> wrote:
> Hi Charly - we are planning to freeze the framework early tomorrow - do you
> think you would have a chance to work on finishing this up today? If not, I
> can take care of it -
> Thanks,
> Antranig
>
> On 25/07/2011 11:28, Antranig Basman wrote:
>>
>> Thanks for this fix, Charly - it is looking nearly ready to go. To get it
>> ready to merge in, could you
>> i) Add test cases to demonstrate the special character cases you have
>> tested, as well as verifying the basic
>> functionality of the improvement to match multiple tokens,
>> ii) Break out the logic at line 1732 into a standalone utility named
>> something like fluid.stringToRegExp,
>> since this might well be valuable in some other situation
>>
>> Thanks,
>> Antranig
>>
>> On 25/07/2011 03:53, charly molter wrote:
>>>
>>> Hello,
>>> Here's my correction I've tried with special characters it works:
>>>
>>> https://github.com/lahabana/infusion/commit/e7e4206f4b0abe727b86ea91ec8682bfccc1475e
>>>
>>> Thank you
>>>
>



-- 
Charly Molter


More information about the fluid-work mailing list