Review of fix to eventFirer.removeListener()

[Anastasia Cheetham]

Laurel, I've just had a look at the patch you attached to
    http://issues.fluidproject.org/browse/FLUID-3672

Your test is nice and simple, and clearly illustrates that removeListener() does not actually remove listeners.

I'm wondering about the fix: The problem is that removeListener() is only trying to remove listeners of type "object" instead of type "function." Your patch changes the condition to look for *both* "object" and "function." I'm not sure whether or not a listener of type "object" would even be reasonable, but my understanding of the event system is not quite as thorough as it could be.

I'm wondering if anyone else has a moment to look at the patch, and comment on whether my suspicion (that removeListener() need only look for "function", and not "object) is correct or not?

-- 
Anastasia Cheetham                       a.cheetham at utoronto.ca
Interface Developer, Fluid Project      http://fluidproject.org
Adaptive Technology Resource Centre   /   University of Toronto