ENGAGE-284 | Language selection
colinbdclark at gmail.com
Tue Jan 26 03:46:53 UTC 2010
I took a look at your patch. You've got a nice start here.
Big picture issues to think about:
* Language selection is closely related to the user work Sveto has implemented. It occurs to me that the language selection screen is going to be the very first time we meet most users--this is probably the best time to create a record for the user and store their language preference. Can you work with Sveto to move the code he's got for handling users in to a more general spot that you can use?
* We'll want to dynamically generate the list of languages based on the museum. Some museums will have content in only one language (bypassing the need for this screen), while others like McCord will have multiple languages. For the Home screen, I started to sketch something out but haven't yet had a chance to commit it to the repository. Can you build your component so that it renders from sample data like this? Here's what I was thinking the museum document would look like for McCord:
"name": "McCord Museum",
* You've got .flc-screenNavigator-backButton classes attached to both links, the English and the French. Class names that start with flc- tend to be unique to a particular component, so you're going to want to make your own. If you're using it to select several of the language links, perhaps flc-languageSelection-links might be appropriate?
* You've wrapped fluid.engage.setCookie() fluid.engage.getCookie() in your own private getter/setter functions, but they don't seem to do anything. You can remove that code and use the methods provided in engageClientUtils.js directly.
* We tend to prefer the use of script blocks in the HTML over calls to jQuery.ready() wherever possible.
I hope this helps,
On 2010-01-25, at 10:14 AM, Andrea Leutgoeb . wrote:
> Hi all,
> I created a jira for the Language Selection screen and uploaded my first version as a patch. It would be great if somebody could have a look at it:
> The next steps will be:
> 1) Specs:
> Language cookie: "language"
> Language labels to be stored: "en", "fr"
> 2) Markup & Css
> Andrea _______________________________________________________
> fluid-work mailing list - fluid-work at fluidproject.org
> To unsubscribe, change settings or access archives,
> see http://fluidproject.org/mailman/listinfo/fluid-work
Technical Lead, Fluid Project
More information about the fluid-work