[Fwd: [Re: Another request for code review]]

Laurel A. Williams laurel.williams at utoronto.ca
Wed Sep 30 15:10:30 UTC 2009


Hi Jacob,

The review below listed as FLUID-3149 - I think you mean FLUID-3189? We 
both made the same mistake and listed the "parent task" rather than the 
child.

Laurel

Jacob Farber wrote:
> Hi Laurel,
> So I have reviewed the jiras below:
> http://issues.fluidproject.org/browse/FLUID-3191
> - reviewed
>
> http://issues.fluidproject.org/browse/FLUID-3190
> - reviewed
>
> http://issues.fluidproject.org/browse/FLUID-3149
> - reviewed, and the cache key strategy seems sound.
>
> http://issues.fluidproject.org/browse/FLUID-3199
> - reviewed
>
> http://issues.fluidproject.org/browse/FLUID-3200
> - reviewed (perhaps it is better to keep your testing material only in your test files? It's too easy to forget to comment out code...)
>
> That all I have.
> Thanks
> Jacob
>
> -----Original Message-----
> From: Laurel A. Williams [mailto:laurel.williams at utoronto.ca] 
> Sent: Tuesday, September 29, 2009 3:59 PM
> To: Jacob Farber
> Subject: [Fwd: [Re: Another request for code review]]
>
> Code for review.
> Laurel
>
> -------- Original Message --------
> Subject: 	[Re: Another request for code review]
> Date: 	Wed, 23 Sep 2009 12:19:27 -0400
> From: 	Laurel A. Williams <laurel.williams at utoronto.ca>
> To: 	fluid-work List <fluid-work at fluidproject.org>
>
>
>
> http://issues.fluidproject.org/browse/FLUID-3200 - PHP
>
> Laurel
>
> Laurel A. Williams wrote:
>   
>> OK....here is the updated list of issues that I hoping someone will
>> review:
>>
>>     
> - only a comment 
>   
>>
>> Laurel
>>
>>
>>
>>
>> _______________________________________________________
>> fluid-work mailing list - fluid-work at fluidproject.org To unsubscribe, 
>> change settings or access archives, see 
>> http://fluidproject.org/mailman/listinfo/fluid-work
>>     
>
>
>
>
>
>   
-------------- next part --------------
A non-text attachment was scrubbed...
Name: laurel_williams.vcf
Type: text/x-vcard
Size: 269 bytes
Desc: not available
URL: <http://fluidproject.org/pipermail/fluid-work/attachments/20090930/35b071fd/attachment.vcf>


More information about the fluid-work mailing list