My Infusion bugs fixed for parade
colinbdclark at gmail.com
Tue Sep 29 23:08:05 UTC 2009
I've fixed several bug parade issues for Infusion 1.1.2, and they're
ready for code review. Here's a description of the issues and the fixes:
These two Image Reorderer issues are pretty closely related, so
they're probably best reviewed as a whole. In short, Image Reorderer
was stuck in the dark ages in terms of the way it found elements in
the DOM. It was still using the short-lived id-prefixed based
strategy, which is more awkward than the usual selector-based approach
we use today.
Along with this, there was some rotten code in ImageReorderer.js that
was causing its default afterMove event listener to not get called,
thus results weren't being sent back to the server. This was a bug in
the default configuration of Image Reorderer specifically, so I was
able to implement my fix without touching Reorderer.js itself.
I had to jump through a few hoops to retain backwards compatibility
with the old id-based style (was it worth it?), but it was possible in
the end. We should probably update the defaults of Image Reorderer to
use the selector-based approach in a future release, and deprecate
that whole code path.
Ultimately, to show this all working in action, I created a whole new
Image Reorderer demo that takes advantage of this more simplified
code. This has now been integrated into the Demo Portal.
Michelle or Antranig are probably good people to review this fix,
since they know the Reorderer codebase best.
The Uploader was broken in Firefox 3.5 due to a regression in
SWFUpload. See my previous post to the list for specifics on the
change. These changes have been reviewed already by Jacob, but I'd
really like it if Eli has a few minutes to take a look, too.
Technical Lead, Fluid Project
More information about the fluid-work