JIRA > Accessibility for demos portal > ask for review (2)

Jacob Farber jacob.farber at utoronto.ca
Tue Sep 29 17:42:37 UTC 2009

Thanks for the patch Joan, looks great. Better still, using the keyboard I found a bug in the code I wrote.

I think it's time to change the demo portal code into component-friendly code :)

From: fluid-work-bounces at fluidproject.org [mailto:fluid-work-bounces at fluidproject.org] On Behalf Of Joan Garcia Vila
Sent: Tuesday, September 29, 2009 12:07 PM
To: Joan García Vila; colinbdclark at gmail.com
Cc: fluid-work at fluidproject.org
Subject: RE: JIRA > Accessibility for demos portal > ask for review (2)

The major changes are in:
fluid-all/infusion/src/webapp/demos/portal/js/demoAssets javascript file.

Also demo.html are afected (2 javascript includes and 1 minor style change in the ul html tag..

--> Missatge original de Joan García Vila (jgarciavila at uoc.edu) per a "colinbdclark at gmail.com" enviat el 29/09/2009 18:03:08


Hello Collin and Justin, this is a review request for the patch posted to the previous jira url.

I've modified the in order to place the role and the aria state (selected) to the tabs created as a response of the XmlHttpRequest.

Hope the code would be good enough.

Please, could you assign me new JIRAS.

Many thanks in advance,
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.idrc.ocad.ca/pipermail/fluid-work/attachments/20090929/1e552a27/attachment.htm>

More information about the fluid-work mailing list