JIRA > Accessibility for demos portal > ask for review (3)

[Jacob Farber]

Hello Joan,
I'm sorry to bring this up again, but it seems like there was a small bug when using the tab key to get outside the code view Tabs. I think the bug is part of something bigger - http://issues.fluidproject.org/browse/FLUID-3225 - and so I couldn't come up with a super graceful work around. Instead, I had to remove the unSelect event and put that functionality inside the onSelect event instead.

One more little point is I just did a small tidy up of the code... it turns out we don't need to say "fluid.activate()" and all the activatable code setup when we can just fire the "click()" event bound to each tab.

I hope this makes sense!
Jacob


-----Original Message-----
From: Colin Clark [mailto:colinbdclark at gmail.com] 
Sent: Sunday, October 04, 2009 10:30 AM
To: Joan Garcia Vila
Cc: Jacob Farber; fluid-work at fluidproject.org
Subject: Re: JIRA > Accessibility for demos portal > ask for review (3)

Hi Joan,

I've reviewed your patch and it looks good. I went ahead and applied  
it to 1.1.2.

While reviewing, I also noticed that we need to take the anchors  
inside each Tab out of the keyboard tab order. I created a one-line  
fix for this and committed.

We're all done with FLUID-3197. Thanks for all your help!

Colin

On 1-Oct-09, at 4:47 AM, Joan Garcia Vila wrote:

> Hi.
>
> This is an "Ask for review" mail.
> Applied Colin's 1 and 2 suggestions to the code.
>
> Jira: http://issues.fluidproject.org/browse/FLUID-3197
>
>
> Thanks in advance,
> cheers,
> joan.

---
Colin Clark
Technical Lead, Fluid Project
http://fluidproject.org