JIRA > Accessibility for demos portal > ask for review (3)

Colin Clark colinbdclark at gmail.com
Sun Oct 4 14:29:45 UTC 2009


Hi Joan,

I've reviewed your patch and it looks good. I went ahead and applied  
it to 1.1.2.

While reviewing, I also noticed that we need to take the anchors  
inside each Tab out of the keyboard tab order. I created a one-line  
fix for this and committed.

We're all done with FLUID-3197. Thanks for all your help!

Colin

On 1-Oct-09, at 4:47 AM, Joan Garcia Vila wrote:

> Hi.
>
> This is an "Ask for review" mail.
> Applied Colin's 1 and 2 suggestions to the code.
>
> Jira: http://issues.fluidproject.org/browse/FLUID-3197
>
>
> Thanks in advance,
> cheers,
> joan.

---
Colin Clark
Technical Lead, Fluid Project
http://fluidproject.org




More information about the fluid-work mailing list