Renderer demo: Code review, please?
a.cheetham at utoronto.ca
a.cheetham at utoronto.ca
Thu Oct 1 15:08:48 UTC 2009
Colin, thanks for your very helpful feedback! I've refactored the code
to implement most of your suggested changes, and to tighten it up a bit.
> Just for clarity's sake, it's probably worth organizing demo.render()
> into discrete sections, perhaps like this:
>
> 1. Setup the model (make the applier, register listeners, set up
> the options)
> 2. Build the component tree
> 3. Bind any event handlers/do setup code
I have re-organized demo.render(), but because of other refactoring I
did, it doesn't break down quite as nicely into the sections you've
described. I'd appreciate a quick look at what I've done...
> Pretty printing would make a huge difference here. The library Jacob
> uses for the portal itself might do it, but I'm not sure.
Yes, it's really almost not helpful at all as it is. I'll have a look
at that library, to see if it has anything useful. Otherwise, I might
just manually code something that pretty-prints it myself...
Again, thanks for the review! I know you're really busy.
--
Anastasia Cheetham a.cheetham at utoronto.ca
Software Designer, Fluid Project
Adaptive Technology Resource Centre / University of Toronto
More information about the fluid-work
mailing list