follow up review

Justin Obara obara.justin at gmail.com
Thu Nov 5 14:29:05 UTC 2009


Hello,

That does seem to address my comments.

Thanks
Justin

On 2009-11-04, at 3:31 PM, Laurel A. Williams wrote:

> Hi Justin
>
> If you would like to do a follow up review, I've addressed your  
> comments about config.php in
> http://issues.fluidproject.org/browse/FLUID-3188. The actual task  
> was to remove the SRC_FILE_NAME and MIN_FILE_NAME values from  
> config.php and replace with a dynamically created version of these  
> file names (which I did in postProcessor.php). While removing those  
> values I re-wrote the instructions on how to use the config.php  
> file, so your suggestions came in handy.
>
> Laurel
>
>
>>>
>>>> http://issues.fluidproject.org/browse/FLUID-3326 - create  
>>>> config.php file that works for the server deploy
>>>
>>> If possible, in config.php, it might be better to have all of the  
>>> fields that need to be set, grouped close together. Currently the  
>>> sets of information that needs to be configured are separated by a  
>>> chunk that says not to touch it.
>>
> <laurel_williams.vcf>




More information about the fluid-work mailing list