Fwd: request for review

Justin Obara obara.justin at gmail.com
Wed Nov 4 16:22:04 UTC 2009


Oops sent this from the wrong e-mail address. Please see below.

Begin forwarded message:

> From: Justin <justin.obara at utoronto.ca>
> Date: November 4, 2009 11:20:41 AM EST
> To: "Laurel A. Williams" <laurel.williams at utoronto.ca>
> Cc: fluid-work List <fluid-work at fluidproject.org>
> Subject: Re: request for review
>
> Hi Laurel,
>
> Please see my comments below.
>
> - Justin
> On 2009-11-04, at 9:41 AM, Laurel A. Williams wrote:
>
>> Hi Justin,
>>
>> Can I impose on you for a few very small reviews?
>>
>> Changes made to the code to aid in deployment (since you've test  
>> driven that twice now, I think you are best to check those)
>> http://issues.fluidproject.org/browse/FLUID-3346 - rename mysql  
>> script
>
> That seems fine.
>
>> http://issues.fluidproject.org/browse/FLUID-3329 - update mysql  
>> script
>
> I actually don't know too much about SQL, but it seems fine at a  
> glance. You may want to run this by someone else though.
>
>> http://issues.fluidproject.org/browse/FLUID-3327 - create  
>> config.php and builder.php
>> appropriate for server and local deployment
>
> There are two files builder.php and builder_local.php. They are only  
> different by a minor change to "DISTANT_PATH". There is a question  
> here of whether it is easier to modify the path since you may have  
> to do this anyways on a local install or to rename and delete files.  
> That being said, speaking to Laurel, she mentioned that by having  
> the two separate files, it will make creating an install script  
> easier.
>
>> http://issues.fluidproject.org/browse/FLUID-3326 - create  
>> config.php file that works for the server deploy
>
> If possible, in config.php, it might be better to have all of the  
> fields that need to be set, grouped close together. Currently the  
> sets of information that needs to be configured are separated by a  
> chunk that says not to touch it.
>
>>
>>
>> Two small css issues:
>> http://issues.fluidproject.org/browse/FLUID-3253 - ie 7 issue for  
>> css (won't fix - unless it comes back after we start to put the  
>> website packaging back on).
>> http://issues.fluidproject.org/browse/FLUID-3342 - spinner image  
>> missing
>
> So you've just added it into the repository, that seems right.
>
>>
>> Laurel
>> < 
>> laurel_williams.vcf 
>> >_______________________________________________________
>> fluid-work mailing list - fluid-work at fluidproject.org
>> To unsubscribe, change settings or access archives,
>> see http://fluidproject.org/mailman/listinfo/fluid-work
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://fluidproject.org/pipermail/fluid-work/attachments/20091104/2b0f44d2/attachment.html>


More information about the fluid-work mailing list