Infusion Builder request for interim review
colinbdclark at gmail.com
Sun Nov 1 17:10:23 UTC 2009
I think your directory structure changes generally look good. A few
comments about naming:
* I'm not sure what's specifically "secure" about the code you've
got in the infusion-builder-secure directory. Does this directory just
contain resources that are "private" to the web server? Or is there a
more descriptive name we can use? Along with this, I assume the stuff
within plain old "infusion-builder" is intended to be located in the
webserver's document directory?
* Your mysqlscript.sql script file could probably be named something
more descriptive. "create-and-clear-builder-cache.sql" or something
along those lines?
And one question about next steps:
* You mention that you've taken the Builder out of CMS Made Simple
(good move), and that it doesn't look as nice as a result. What's your
plan for making it look good again?
On 23-Oct-09, at 4:39 PM, Laurel A. Williams wrote:
> Following up on discussions with Colin yesterday, I've made some
> revisions to the Infusion Builder which should to be reviewed.
> You can find the issues that I've addressed using the following JIRA
> filter: http://issues.fluidproject.org/secure/IssueNavigator.jspa?mode=hide&requestId=10265
> Essentially, I've rearranged the directory structure in svn to
> better reflect the deployment of the tool. I've corrected some
> configuration issues to simplify deployment. I think more can be
> done, but this is a start and I wanted to move in relatively small
> steps to correct the issues that Colin found. Updated installation
> instructions can be found here: http://wiki.fluidproject.org/display/fluid/Deploying+the+Infusion+Builder
> . Hopefully we can test drive this first attempt early next week and
> try to find problem steps.
> A clean install can be found here: http://22.214.171.124/infusion-builder/html/CustomBuild.html
> I've taken the Infusion Builder out of the CMSMS entirely, so it
> doesn't look as nice any more, but it seems to be working fine.
Technical Lead, Fluid Project
More information about the fluid-work