patch for json files - jira 2648 and 2639

Laurel A. Williams laurel.williams at utoronto.ca
Tue May 5 18:02:36 UTC 2009


Thanks Colin,

Do you have any thoughts on the cssFiles option in other components and 
libs json files such as Pager, Inline Edit, and even jQuery tool tips?

Laurel

Colin Clark wrote:
>
> Thanks for the patch. I've taken some time to review it, and have a 
> couple of comments:
>
>  * The new "name" and "description" properties in each dependency 
> declaration file look good. Nice work!
>
>  * The FSS module appears to a have a couple of problems that may 
> require a bit more thinking with Jacob and Michelle in the mix. I 
> think we probably don't want to treat FSS as one big module, but break 
> it up into several smaller chunks instead. Perhaps a separate module 
> for reset, layout, text, and themes. My rationale for this is that 
> several parts of the FSS are optional, particularly the reset file. If 
> the reset file were included without the user specifically asking for 
> it, visual problems will ensue.
>
>  * The dependencies for each module should be updated to also include 
> dependencies on these new FSS modules.
>
> So I'm going to suggest that you submit a version of the patch with 
> just the changes to "name" and "description." We'll get that committed 
> ASAP. We can hash out any of the issues related to adding the FSS 
> modules in the channel, and then when you're ready, you can submit a 
> second patch with the CSS changes.
>
> Hopefully this isn't too inconvenient. Great first patch!
>
> Colin
>
> ---
> Colin Clark
> Technical Lead, Fluid Project
> Adaptive Technology Resource Centre, University of Toronto
> http://fluidproject.org
>



More information about the fluid-work mailing list