FLUID-2936

[Alison Benjamin]

Hi,

My first patch for FLUID-2936 made the progress unit test fail
http://build.fluidproject.org/infusion/tests/component-tests/progress/html/Progress-test.html

So I have written a second patch to address this. It affects two
files. An assertion in ProgressTests.js was looking for the aria-live
property, which our first patch removed. This second patch removes
lines in ProgressTests.js that test for this. In Progress.js, the one
change I made was in the initARIA function, where I added the line
ariaElement.attr("aria-busy", "false"); .

I hope this OK, and thank you for the review.

Alison










On Fri, Jul 10, 2009 at 10:26 AM, Alison
Benjamin<alison.benjamin at gmail.com> wrote:
> Thank you for your help on this Colin.
>
> On Thu, Jul 9, 2009 at 5:40 PM, Colin Clark <colin.clark at utoronto.ca> wrote:
>>
>> Hey Alison,
>>
>> On 9-Jul-09, at 3:50 PM, Alison Benjamin wrote:
>>>
>>> This is a patch Colin and I have put together to address
>>> http://issues.fluidproject.org/browse/FLUID-2936
>>>
>>> This improves the indications a JAWS user will get about progress. It
>>> doesn't solve the problem of the user needing an indication of when progress
>>> is done. We suspect this problem lies with JAWS. Testing with another screen
>>> reader like orca, which also has ARIA support, could help isolate the
>>> issue...
>>
>>
>> Thanks for the patch! I tweaked it a tiny bit and committed it to the
>> repository. Now all we need to do is figure out how to get JAWS to announce
>> when it is completed!
>>
>> Keep these a11y patches coming; they're awesome!
>>
>> Colin
>>
>> ---
>> Colin Clark
>> Technical Lead, Fluid Project
>> Adaptive Technology Resource Centre, University of Toronto
>> http://fluidproject.org
>>
>
>
-------------- next part --------------
Index: components/progress/js/Progress.js
===================================================================
--- components/progress/js/Progress.js	(revision 7562)
+++ components/progress/js/Progress.js	(working copy)
@@ -89,10 +89,12 @@
         ariaElement.attr("aria-valuemax", "100");
         ariaElement.attr("aria-valuenow", "0");
         ariaElement.attr("aria-valuetext", "");
+		ariaElement.attr("aria-busy", "false");
     };
     
     var updateARIA = function (that, percent) {
-        var busy = percent < 100 && percent > 0;
+        
+		var busy = percent < 100 && percent > 0;
         that.ariaElement.attr("aria-busy", busy);
         that.ariaElement.attr("aria-valuenow", percent);    
         if (busy) {
Index: tests/component-tests/progress/js/ProgressTests.js
===================================================================
--- tests/component-tests/progress/js/ProgressTests.js	(revision 7569)
+++ tests/component-tests/progress/js/ProgressTests.js	(working copy)
@@ -324,7 +324,7 @@
             jqUnit.assertFalse("Before init: valuemax should not exist", ARIAcontainer.attr("aria-valuemax"));
             jqUnit.assertFalse("Before init: valuenow should not exist", ARIAcontainer.attr("aria-valuenow"));
             jqUnit.assertFalse("Before init: busy should not exist", ARIAcontainer.attr("aria-busy"));
-            jqUnit.assertFalse("Before init: live should not exist", ARIAcontainer.attr("aria-live"));
+            
         
             progressBar = createProgressBar("#progress-container", {animate: "none"});
             
@@ -332,7 +332,7 @@
             jqUnit.assertEquals("After Init: valuemin should be ", "0", ARIAcontainer.attr("aria-valuemin"));
             jqUnit.assertEquals("After Init: valuemax should be ", "100", ARIAcontainer.attr("aria-valuemax"));
             jqUnit.assertEquals("After Init: valuenow should be ", "0", ARIAcontainer.attr("aria-valuenow"));
-            jqUnit.assertEquals("After Init: live should be ", "assertive", ARIAcontainer.attr("aria-live"));
+            
             jqUnit.assertEquals("After Init: busy should be ", "false", ARIAcontainer.attr("aria-busy"));
                   
         });
@@ -347,6 +347,7 @@
             
             progressBar = createProgressBar("#progress-container", {animate: "none"});
             
+			
             jqUnit.assertEquals("Start: busy should be ", "false", ARIAcontainer.attr("aria-busy"));
             jqUnit.assertEquals("Start: valuenow should be ", "0", ARIAcontainer.attr("aria-valuenow"));