custom build tool - FLUID 3008

[Colin Clark]

Hey Laurel,

Several code reviews and responses in one...

> The following JIRA addresses Colin's point below about  
> BuilderUtilityClass.
> http://issues.fluidproject.org/browse/FLUID-3005
>
> I've committed the changes to address this (commit 7526) if Colin  
> and others would like to check it out.

Looks good.

> If data is posted but is invalid, it is ignored by our server side  
> code, which returns a default minified version of infusion in this  
> case.

That makes sense to me.

On 8-Jul-09, at 10:30 AM, Laurel A. Williams wrote:
> More php code for review in the incubator/custom-build project.
>
> This is the last commit to address the issues that Colin mentioned  
> in his email reviewing the postProcessor code. I have written a  
> function to dynamically obtain an array of modules from the  
> build.properties file - you can find the new function in  
> BuilderUtilities (retrieveModuleList). I also wrote tests for the  
> part of this function that parses the data from the build.properties  
> file. In addition I altered the code in postProcessor and PostClass  
> to use the new function.

Looks good.

Keep it up! I really appreciate that you're committing small changes  
to your incubator space and then pinging the list on a regular basis  
for advice and code review. This sets a great example for all the  
other prospective committers who are working in the incubator. :)

Thanks so much,

Colin

---
Colin Clark
Technical Lead, Fluid Project
Adaptive Technology Resource Centre, University of Toronto
http://fluidproject.org