custom build tool: FLUID-3007
Laurel A. Williams
laurel.williams at utoronto.ca
Tue Jul 7 18:49:23 UTC 2009
Am I driving anyone crazy yet? I do like to work in small cycles, so
having commit access is wonderful! Hope my fav reviewers can keep up
with things and that they will let me know if I could do things in
another way to make things easier for reviewing.
http://issues.fluidproject.org/browse/FLUID-3007 addresses Colin's
comment about the global variables in postProcessor.php.
"In postProcessor.php, I notice that you define $minified and $includes
as global variables. How come? If it's necessary, is there a way you can
define a class instead that will store this state and the methods that
depend on it without requiring globals? "
I've revised postProcessor to use a class called PostClass. PostClass
encompases the $minified, $includes, and $excludes variables and the
functions that operate on them (as suggested). Mostly this just required
me to move some code from the newly created BuildUtilities into this
class (and a move of the tests).
Code is checked in and ready for review.
Laurel
--
Laurel A. Williams
Adaptive Technology Resource Centre
University of Toronto
More information about the fluid-work
mailing list