FLUID-3005

Laurel A. Williams laurel.williams at utoronto.ca
Tue Jul 7 16:13:03 UTC 2009


The following JIRA addresses Colin's point below about BuilderUtilityClass.
http://issues.fluidproject.org/browse/FLUID-3005

I've committed the changes to address this (commit 7526) if Colin and 
others would like to check it out.

Laurel

>>> I can't quite tell why you've structured your BuilderUtilityClass as 
>>> a full-fledged class with instance methods. There seems to be no 
>>> state here, just a couple of standalone utility functions. Indeed 
>>> the naming suggests as much--it's not an object with any real 
>>> identity, just a collection of functions. Maybe it's easier to ditch 
>>> the class and just invoke these functions directly? Or perhaps 
>>> there's a bit more thinking about how to structure the various bits 
>>> of logic in your code?
>
> I appreciate the point about the BuilderUtilityClass - It was a first 
> pass at getting the unit tests to work - all the SimpleTest examples 
> used a Class rather than a collection of functions, so I modelled the 
> examples without thinking. I will revise that in my next iteration.

-- 
Laurel A. Williams
Adaptive Technology Resource Centre
University of Toronto




More information about the fluid-work mailing list