Builder code review for FLUID-3427 and FLUID-3399 request for preliminary review

Laurel Williams laurel.williams at utoronto.ca
Tue Dec 15 02:48:44 UTC 2009


Thanks Colin for the review. I agree and can certainly fix that easily

Would really appreciate your eyes on 
http://issues.fluidproject.org/browse/FLUID-3399. I checked in further 
code today and it seems to work...just need to figure out how to 
populate the model. But any comments on the code and technique would be 
appreciated.

Laurel

Colin Clark wrote:
> Hi Laurel,
>
> I reviewed your changes to the PHP tests and the Builder Ant deploy 
> script for FLUID-3427, and they look really good. I caught one issue 
> which I've asked about on the ticket itself:
>
> http://issues.fluidproject.org/browse/FLUID-3427
>
> In short, I'm wondering if we want the "daily" target to depend on 
> "backup," or whether that stage of the process is only appropriate for 
> production deployments? Let me know what you think about this issue.
>
> Colin
>
> ---
> Colin Clark
> Technical Lead, Fluid Project
> Adaptive Technology Resource Centre, University of Toronto
> http://fluidproject.org
>




More information about the fluid-work mailing list