oh dear - a rather large request for review

Laurel A. Williams laurel.williams at utoronto.ca
Wed Dec 2 19:18:40 UTC 2009

Colin Clark wrote:
> Hi Laurel,
> I've managed to get through your list of requested reviews, and don't 
> have any specific comments about your fixes. Most of them were small 
> issues, and your changes look just fine.
> The one major change was your Ant scripts for managing the deploy 
> process. I haven't had a chance to actually test drive the deploy 
> process for Builder yet, but I can say that from a code perspective 
> your Ant scripts are small, simple, and well-factored. Nicely done!
> Reviewing a huge block of JIRAs like this can be pretty overwhelming. 
> As a favour to code reviewers, could you perhaps sort your requests 
> into two categories: 1) substantive code changes, and 2) minor tweaks? 
> Some of these little issues can probably go without distinct code 
> review beyond, say, running the unit tests. It also helps people to 
> prioritize which issues are most important to look at first. That way, 
> you might increase your chances of speedy review for the big ones.
Will do Colin!


> I hope this helps,
> Colin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: laurel_williams.vcf
Type: text/x-vcard
Size: 269 bytes
Desc: not available
URL: <https://lists.idrc.ocad.ca/pipermail/fluid-work/attachments/20091202/f7be9fdb/attachment.vcf>

More information about the fluid-work mailing list