FLUID-1935 Review: Inconsistencies?

Eli Cochran eli at media.berkeley.edu
Fri Dec 12 23:03:01 UTC 2008


The reason that we went with this scheme was to be more consistent  
with the fl- namespace set up by the new skinning system.

- Eli

On Dec 12, 2008, at 2:21 PM, Anastasia Cheetham wrote:

>
> I've reviewed these css changes, and commented on the JIRA, but  
> since it's late and most people won't necessarily be tracking the  
> JIRAs, I've reproduced my comments below:
>
>
>
> I'm seeing some inconsistency in naming of styles for components.  
> The uploader styles all start with "fl-uploader-" i.e. "fl-"  
> followed by the component name (see fluid.components.uploader.css).
>
> But other components use style names that start with the component  
> name i.e. there is no "fl-" prefix (e.g. "ui_options_container" and  
> "ui-dialog" and "inlineEdit-invitation" and "orderable-*")
>
> Should we decide on a convention and stick to it, or was there a  
> reason for the existing scheme?
>
> -- 
> Anastasia Cheetham                   a.cheetham at utoronto.ca
> Software Designer, Fluid Project    http://fluidproject.org
> Adaptive Technology Resource Centre / University of Toronto
>
> _______________________________________________________
> fluid-work mailing list - fluid-work at fluidproject.org
> To unsubscribe, change settings or access archives,
> see http://fluidproject.org/mailman/listinfo/fluid-work

. . . . . . . . . . .  .  .   .    .      .         .              .                     .

Eli Cochran
user interaction developer
ETS, UC Berkeley





More information about the fluid-work mailing list