Code review for SWFUpload 2.2.0 upgrade (FLUID-1768)

[Colin Clark]

Hi everyone,

As many of you know, the process of upgrading our Uploader component  
to use SWFUpload 2.2.0 has been a difficult one. This latest version  
of the SWFUpload library is ridden with bugs, and a number of  
accessibility challenges have emerged due to the replacement of the  
DHTML Browse button with a Flash-based version for "security" reasons.

I'll send out a longer email that explains the issues in depth, but  
suffice it to say for now that I've had to do a fair bit of wrangling  
to get it all working correctly.

I've attached a patch to the FLUID-1768 JIRA ticket that includes the  
upgrade to SWFUpload 2.2.0, along with a new decorator for the  
Uploader that is responsible for configuring the DOM and the component  
correctly based on the user's environment. DIfferent behaviour is  
required across browsers and versions of Flash, and this decorator is  
designed to hide away these hacks from the rest of the component and  
the implementor.

http://issues.fluidproject.org/browse/FLUID-1768

This patch does not include full Flash 10 support yet, but it does  
patch all the Flash 9-related bugs in SWFUpload 2.2.0. Expect another  
patch from me shortly with the Flash 10 code completed.

In the meantime, since this is a blocker on the bug parade, I'd  
appreciate someone taking the time to review this change.

Thanks,

Colin

PS. Eli, this patch may conflict with your patch for FLUID-1947 (which  
is pending my review). Don't worry; I'll take on the work of merging  
the two patches once they have both been reviewed.

---
Colin Clark
Technical Lead, Fluid Project
Adaptive Technology Resource Centre, University of Toronto
http://fluidproject.org