[contrib] svn commit: r10215 - in utoronto/fluid/components/trunk/src/webapp/component-templates: js/fluid js/fluid/nls test/tests

[Antranig Basman]

Something about this commit has created a lightbox which causes
Firefox to crash hard, when the component is viewed in the Gallery.

Unfortunately I have already committed a couple of changes over the top, 
but I backed out a bit locally to verify that they didn't change the
situation.
If I comment out all references to dojo.I18N, nls and the tooltip stuff
in Lightbox.js, the component works again in the Gallery.
This is Firefox 1.5.0.12 running on Windows - whilst the local template
runs fine, and passes all the tests, loading the lightbox Sakai tool
crashes the entire browser hard - the event loop locks up, although the
process remains at 0% CPU with no apparent activity.
Other than saying it is something to do with the tooltip/NLS code it
is a bit hard to diagnose what the cause could be.

That said, I am not convinced that this particular localisation strategy
is the best idea, in that we already have a complete set of localisation
performed on the server-side. Of course, it is as yet unclear whether the
current problem is caused by the dojo localisation code, or by the dojo
tooltip code :) But the next experiment to be tried is backing out JUST
the use of Dojo I18N, and injecting the correct localised message from
the server. This current approach results in the localisation team having
2 places to look for localisation data rather than one, and is not very
framework-independent.

I have to go home now, but will experiment a bit tomorrow...
Please send reports whether this crash is reproducible in other 
environments.

Cheers,
A.



jonathan.hung at utoronto.ca wrote:
> 
> Details: http://source.sakaiproject.org/viewsvn?root=contrib&view=rev&rev=10215
> 
> Author: jonathan.hung at utoronto.ca
> Date: 2007-06-22 15:11:58 -0400 (Fri, 22 Jun 2007)
> New Revision: 10215
> 
> Added:
> utoronto/fluid/components/trunk/src/webapp/component-templates/js/fluid/nls/
> utoronto/fluid/components/trunk/src/webapp/component-templates/js/fluid/nls/instructions.js
> Modified:
> utoronto/fluid/components/trunk/src/webapp/component-templates/js/fluid/Lightbox.js
> utoronto/fluid/components/trunk/src/webapp/component-templates/test/tests/LightboxTests.js
> utoronto/fluid/components/trunk/src/webapp/component-templates/test/tests/UtilitiesTests.js
> Log:
> Added Tooltip to Lightbox. Updated Utilities tests. [MD, JH]
> 
> ----------------------
> This automatic notification message was sent by Sakai Collab (https://collab.sakaiproject.org/portal) from the Source site.
> You can modify how you receive notifications at My Workspace > Preferences.