[Commits] [fluid-project/infusion] e84f7a: FLUID-6278: fixed bug with queue speech synthesis

Antranig Basman noreply at github.com
Thu Oct 31 20:26:21 UTC 2019 

  Branch: refs/heads/master
  Home:   https://github.com/fluid-project/infusion
  Commit: e84f7a2113ce8bd09c1296c9fda0181456d3c0dc
      https://github.com/fluid-project/infusion/commit/e84f7a2113ce8bd09c1296c9fda0181456d3c0dc
  Author: Justin Obara <obara.justin at gmail.com>
  Date:   2019-09-13 (Fri, 13 Sep 2019)

  Changed paths:
    M src/components/textToSpeech/js/TextToSpeech.js

  Log Message:
  -----------
  FLUID-6278: fixed bug with queue speech synthesis

Depending on timing, it was possible that mutliple queued speech texts 
would only synthesize the first, if they were added before the previous 
one finished.


  Commit: 139c6d63addc2ffc1be6efd023bef8b1c358eaf6
      https://github.com/fluid-project/infusion/commit/139c6d63addc2ffc1be6efd023bef8b1c358eaf6
  Author: Justin Obara <obara.justin at gmail.com>
  Date:   2019-09-13 (Fri, 13 Sep 2019)

  Changed paths:
    M demos/orator/index.html
    M src/components/orator/js/Orator.js

  Log Message:
  -----------
  FLUID-6278: In progress commit. Contains debug and test code and markup.


  Commit: 62a0c0e8387ec0ae5d104ce30dccec3fa0ccf319
      https://github.com/fluid-project/infusion/commit/62a0c0e8387ec0ae5d104ce30dccec3fa0ccf319
  Author: Justin Obara <obara.justin at gmail.com>
  Date:   2019-09-19 (Thu, 19 Sep 2019)

  Changed paths:
    M src/components/orator/css/Orator.css
    M src/components/orator/js/Orator.js
    M src/components/textToSpeech/js/TextToSpeech.js

  Log Message:
  -----------
  FLUID-6278: Further in progress work.

The domReader is mostly working again. The current issue is that if the 
selection reader is running and we start the domReader, the onStop event 
from the selection reader's utterance triggers the handler in the 
domReader which confuses the state. This results in the highlighting not 
appearing and the button controller state to be incorrect. Also need to 
fix the tests and comments.


  Commit: 2615760b44198a7b8968b476c0b2f4cb22e0fde1
      https://github.com/fluid-project/infusion/commit/2615760b44198a7b8968b476c0b2f4cb22e0fde1
  Author: Justin Obara <obara.justin at gmail.com>
  Date:   2019-09-19 (Thu, 19 Sep 2019)

  Changed paths:
    M src/components/orator/js/Orator.js
    M src/components/textToSpeech/js/TextToSpeech.js

  Log Message:
  -----------
  FLUID-6278: domReader appears to be fully working again. 

- Need to update comments
- Need to update tests
- Need to update selection reader to switch synthesizers with language 
changes.


  Commit: 64a17d22b50734dfe03a1c1049878faadbef0428
      https://github.com/fluid-project/infusion/commit/64a17d22b50734dfe03a1c1049878faadbef0428
  Author: Justin Obara <obara.justin at gmail.com>
  Date:   2019-09-19 (Thu, 19 Sep 2019)

  Changed paths:
    M src/components/textToSpeech/js/TextToSpeech.js

  Log Message:
  -----------
  FLUID-6278: Updated code comments


  Commit: 7353d4a8865724eb21d78b69dd21beb15619d461
      https://github.com/fluid-project/infusion/commit/7353d4a8865724eb21d78b69dd21beb15619d461
  Author: Justin Obara <obara.justin at gmail.com>
  Date:   2019-09-23 (Mon, 23 Sep 2019)

  Changed paths:
    M src/components/orator/js/Orator.js

  Log Message:
  -----------
  FLUID-6278: Some linting


  Commit: 585db828d8d4be02de1a792066eed81b7b27e679
      https://github.com/fluid-project/infusion/commit/585db828d8d4be02de1a792066eed81b7b27e679
  Author: Justin Obara <obara.justin at gmail.com>
  Date:   2019-09-23 (Mon, 23 Sep 2019)

  Changed paths:
    M src/components/orator/js/Orator.js

  Log Message:
  -----------
  FLUID-6278: Broke out parseQueue array increment into separate function


  Commit: ede93dbda910cd625a90e96d36ec5f0726f71c10
      https://github.com/fluid-project/infusion/commit/ede93dbda910cd625a90e96d36ec5f0726f71c10
  Author: Justin Obara <obara.justin at gmail.com>
  Date:   2019-09-23 (Mon, 23 Sep 2019)

  Changed paths:
    M src/components/orator/js/Orator.js

  Log Message:
  -----------
  FLUID-6278: In progress work to update selection reader

- have roughed in a fluid.orator.selectionReader.parseRange method for 
parsing a range element sourced from a selection. Not yet hooked up.


  Commit: 4f07bbd8c8be7aef7e686e53691254e48a6786f2
      https://github.com/fluid-project/infusion/commit/4f07bbd8c8be7aef7e686e53691254e48a6786f2
  Author: Justin Obara <obara.justin at gmail.com>
  Date:   2019-09-24 (Tue, 24 Sep 2019)

  Changed paths:
    M src/components/orator/js/Orator.js
    M src/components/textToSpeech/js/TextToSpeech.js

  Log Message:
  -----------
  FLUID-6278: In progress commit. selectionReader working.

- The selectionReader is able to switch languages during synthesizing

- Need to update tests
- Need to update comments
- Need to refactor/clean up code
- Need to fix button location for selectionReader


  Commit: 9648437de9eaa2b930104d1080b17700e10248e6
      https://github.com/fluid-project/infusion/commit/9648437de9eaa2b930104d1080b17700e10248e6
  Author: Justin Obara <obara.justin at gmail.com>
  Date:   2019-09-26 (Thu, 26 Sep 2019)

  Changed paths:
    M src/components/orator/js/Orator.js
    M src/components/textToSpeech/js/TextToSpeech.js
    M src/framework/core/js/TextNodeParser.js

  Log Message:
  -----------
  FLUID-6278: Refactoring of fluid.textNodeParser.parser

- the parser will return all of the parsed TextNodeData objects in an 
array.
- still fires events for each text node parsed, but now data is passed 
as a TextNodeData object instead of individual arguments.


  Commit: 98b77387b346a3c7cdc8557c3ed6635bcc17dba7
      https://github.com/fluid-project/infusion/commit/98b77387b346a3c7cdc8557c3ed6635bcc17dba7
  Author: Justin Obara <obara.justin at gmail.com>
  Date:   2019-09-26 (Thu, 26 Sep 2019)

  Changed paths:
    M src/components/textToSpeech/js/TextToSpeech.js
    M src/framework/core/js/TextNodeParser.js

  Log Message:
  -----------
  FLUID-6278: Updating comments


  Commit: c00c4c5ec8e00c659aa58ca802a393803b173d40
      https://github.com/fluid-project/infusion/commit/c00c4c5ec8e00c659aa58ca802a393803b173d40
  Author: Justin Obara <obara.justin at gmail.com>
  Date:   2019-09-26 (Thu, 26 Sep 2019)

  Changed paths:
    M src/components/orator/js/Orator.js

  Log Message:
  -----------
  FLUID-6278: Refactoring and comment updates.


  Commit: 67b63428008bdd0deb04aaf697a9dbf53cd617bc
      https://github.com/fluid-project/infusion/commit/67b63428008bdd0deb04aaf697a9dbf53cd617bc
  Author: Justin Obara <obara.justin at gmail.com>
  Date:   2019-09-27 (Fri, 27 Sep 2019)

  Changed paths:
    M src/framework/core/js/TextNodeParser.js
    M tests/framework-tests/core/js/TextNodeParserTests.js

  Log Message:
  -----------
  FLUID-6278: Updating TextNodeParser test, and added a related bug fix.


  Commit: 1f0ac93db78a3422cbcec5e643fd6abac7d9aa6c
      https://github.com/fluid-project/infusion/commit/1f0ac93db78a3422cbcec5e643fd6abac7d9aa6c
  Author: Justin Obara <obara.justin at gmail.com>
  Date:   2019-09-30 (Mon, 30 Sep 2019)

  Changed paths:
    M tests/component-tests/textToSpeech/js/TextToSpeechTests.js

  Log Message:
  -----------
  FLUID-6278: Updating TextToSpeech tests.

- cleaned up some naming issues
- Added test for promise returned by queueSpeech


  Commit: de0347598f2ba315ca55594a206fa70e8c15d04d
      https://github.com/fluid-project/infusion/commit/de0347598f2ba315ca55594a206fa70e8c15d04d
  Author: Justin Obara <obara.justin at gmail.com>
  Date:   2019-09-30 (Mon, 30 Sep 2019)

  Changed paths:
    M src/components/textToSpeech/js/TextToSpeech.js
    M tests/component-tests/textToSpeech/js/TextToSpeechTests.js

  Log Message:
  -----------
  FLUID-6278: Moving checkTTSSupport to tests.

- Chrome no longer supports calling speechSynthesis.speak witout user 
activation. Meaning this check may fail even when TTS is supported. 
https://developers.google.com/web/updates/2018/10/chrome-71-deps-rems#remove_speechsynthesisspeak_without_user_activation
- Also it was only ever used for the tests. So makes sense to include it 
there.


  Commit: e497a382dc3d17908d19dab263624aabb0674021
      https://github.com/fluid-project/infusion/commit/e497a382dc3d17908d19dab263624aabb0674021
  Author: Justin Obara <obara.justin at gmail.com>
  Date:   2019-10-02 (Wed, 02 Oct 2019)

  Changed paths:
    M src/components/orator/js/Orator.js
    M src/components/textToSpeech/js/MockTTS.js
    M src/components/textToSpeech/js/TextToSpeech.js
    M tests/component-tests/orator/html/Orator-test.html
    M tests/component-tests/orator/js/OratorTests-Utils.js
    M tests/component-tests/orator/js/OratorTests.js

  Log Message:
  -----------
  FLUID-6278: fixing/updating tests

Includes some refactoring to address issues uncovered by the tests.


  Commit: 172c207ec234c6144f5769587e26ff1a50705513
      https://github.com/fluid-project/infusion/commit/172c207ec234c6144f5769587e26ff1a50705513
  Author: Justin Obara <obara.justin at gmail.com>
  Date:   2019-10-02 (Wed, 02 Oct 2019)

  Changed paths:
    M src/framework/preferences/js/SyllabificationEnactor.js

  Log Message:
  -----------
  FLUID-6278: Updating syllabification with changes to textNodeParser


  Commit: 78394d422ffe5a0d75a33ce614c9a96b1bb496f2
      https://github.com/fluid-project/infusion/commit/78394d422ffe5a0d75a33ce614c9a96b1bb496f2
  Author: Justin Obara <obara.justin at gmail.com>
  Date:   2019-10-02 (Wed, 02 Oct 2019)

  Changed paths:
    M demos/orator/index.html
    M demos/prefsFramework/index.html

  Log Message:
  -----------
  FLUID-6278: Cleaning and updating lang values for TTS related demos.


  Commit: 21185b5fb5ca4c73a1071e686af2cc4c7f32adcb
      https://github.com/fluid-project/infusion/commit/21185b5fb5ca4c73a1071e686af2cc4c7f32adcb
  Author: Justin Obara <obara.justin at gmail.com>
  Date:   2019-10-02 (Wed, 02 Oct 2019)

  Changed paths:
    M src/components/orator/js/Orator.js
    M src/components/textToSpeech/js/TextToSpeech.js
    M src/framework/core/js/TextNodeParser.js
    M tests/component-tests/orator/js/OratorTests-Utils.js
    M tests/component-tests/orator/js/OratorTests.js
    M tests/component-tests/textToSpeech/js/TextToSpeechTests.js
    M tests/framework-tests/core/js/TextNodeParserTests.js

  Log Message:
  -----------
  FLUID-6278: Linting


  Commit: b4b96ea567cdbf31e0c7a1fd35072ab0f896dbb2
      https://github.com/fluid-project/infusion/commit/b4b96ea567cdbf31e0c7a1fd35072ab0f896dbb2
  Author: Justin Obara <obara.justin at gmail.com>
  Date:   2019-10-02 (Wed, 02 Oct 2019)

  Changed paths:
    M tests/component-tests/orator/js/OratorTests.js

  Log Message:
  -----------
  FLUID-6278: Expanding test coverage for Orator tests.


  Commit: 67e23f57eaf71db9b7f68791496c656aafcca90f
      https://github.com/fluid-project/infusion/commit/67e23f57eaf71db9b7f68791496c656aafcca90f
  Author: Justin Obara <obara.justin at gmail.com>
  Date:   2019-10-07 (Mon, 07 Oct 2019)

  Changed paths:
    M src/components/orator/js/Orator.js

  Log Message:
  -----------
  FLUID-6278: Ignoring boundary events for "sentence" boundaries.

This was causing an issue with the parseQueueIndex incrementation 
algorithm for switching languages because we'd get two boundary events 
at the start of each sentence. One for the sentence and one for the 
word.


  Commit: 9fdccb16f8809b252daaf6b28a848640e2509a62
      https://github.com/fluid-project/infusion/commit/9fdccb16f8809b252daaf6b28a848640e2509a62
  Author: Justin Obara <obara.justin at gmail.com>
  Date:   2019-10-07 (Mon, 07 Oct 2019)

  Changed paths:
    A .editorconfig
    M .npmignore
    M src/framework/core/css/fluidDebugging.css

  Log Message:
  -----------
  Merge branch 'master' into FLUID-6278


  Commit: 4ef5356a506d318686df7d010c396a008b0d459a
      https://github.com/fluid-project/infusion/commit/4ef5356a506d318686df7d010c396a008b0d459a
  Author: Justin Obara <obara.justin at gmail.com>
  Date:   2019-10-07 (Mon, 07 Oct 2019)

  Changed paths:
    M tests/component-tests/orator/js/OratorTests.js

  Log Message:
  -----------
  FLUID-6278: Updating tests for changes to boundary event handling.


  Commit: eaf1dd9b4be2e59a5e46252d8fa20c598a362a49
      https://github.com/fluid-project/infusion/commit/eaf1dd9b4be2e59a5e46252d8fa20c598a362a49
  Author: Justin Obara <obara.justin at gmail.com>
  Date:   2019-10-22 (Tue, 22 Oct 2019)

  Changed paths:
    M src/components/textToSpeech/js/MockTTS.js
    M tests/framework-tests/preferences/html/CaptionsEnactor-test.html
    M tests/framework-tests/preferences/html/LetterSpaceEnactor-test.html
    M tests/framework-tests/preferences/html/LocalizationEnactor-test.html
    M tests/framework-tests/preferences/html/WordSpaceEnactor-test.html

  Log Message:
  -----------
  FLUID-6278: Cleaned up mockTTS speak override.

Also removed imports of mockTTS where it wasn't being used.


  Commit: 2341a96c2baf3f5aacf227cd75c9ac0cb8510e20
      https://github.com/fluid-project/infusion/commit/2341a96c2baf3f5aacf227cd75c9ac0cb8510e20
  Author: Justin Obara <obara.justin at gmail.com>
  Date:   2019-10-24 (Thu, 24 Oct 2019)

  Changed paths:
    M tests/component-tests/textToSpeech/js/TextToSpeechTests.js

  Log Message:
  -----------
  FLUID-6278: Updating comment


  Commit: 2a53dd823da0ce03d7c14416677b92ce58bd626f
      https://github.com/fluid-project/infusion/commit/2a53dd823da0ce03d7c14416677b92ce58bd626f
  Author: Justin Obara <obara.justin at gmail.com>
  Date:   2019-10-31 (Thu, 31 Oct 2019)

  Changed paths:
    M examples/framework/preferences/shared/js/primarySchema.js
    M src/components/orator/css/Orator.css
    M src/components/orator/js/Orator.js
    M src/framework/preferences/js/LetterSpacePanel.js
    M src/framework/preferences/js/LetterSpaceSchemas.js
    M src/framework/preferences/js/LocalizationPanel.js
    M src/framework/preferences/js/LocalizationSchemas.js
    M src/framework/preferences/js/Panels.js
    M src/framework/preferences/js/StarterGrades.js
    M src/framework/preferences/js/StarterSchemas.js
    M src/framework/preferences/js/WordSpacePanel.js
    M src/framework/preferences/js/WordSpaceSchemas.js
    M tests/component-tests/orator/js/OratorTests-Utils.js
    M tests/component-tests/orator/js/OratorTests.js
    M tests/framework-tests/core/js/FluidJSTests.js
    M tests/framework-tests/preferences/js/AuxBuilderTests.js
    M tests/framework-tests/preferences/js/LocalizationPanelTests.js
    M tests/framework-tests/preferences/js/PanelsTests.js
    M tests/framework-tests/preferences/js/PrimaryBuilderTests.js
    M tests/framework-tests/preferences/js/SelfVoicingEnactorTests.js

  Log Message:
  -----------
  Merge branch 'master' into FLUID-6278


  Commit: f8da9a344c2d38171049b9c38592d57c1906891e
      https://github.com/fluid-project/infusion/commit/f8da9a344c2d38171049b9c38592d57c1906891e
  Author: Antranig Basman <antranig.basman at colorado.edu>
  Date:   2019-10-31 (Thu, 31 Oct 2019)

  Changed paths:
    M demos/orator/index.html
    M demos/prefsFramework/index.html
    M src/components/orator/css/Orator.css
    M src/components/orator/js/Orator.js
    M src/components/textToSpeech/js/MockTTS.js
    M src/components/textToSpeech/js/TextToSpeech.js
    M src/framework/core/js/TextNodeParser.js
    M src/framework/preferences/js/SyllabificationEnactor.js
    M tests/component-tests/orator/html/Orator-test.html
    M tests/component-tests/orator/js/OratorTests-Utils.js
    M tests/component-tests/orator/js/OratorTests.js
    M tests/component-tests/textToSpeech/js/TextToSpeechTests.js
    M tests/framework-tests/core/js/TextNodeParserTests.js
    M tests/framework-tests/preferences/html/CaptionsEnactor-test.html
    M tests/framework-tests/preferences/html/LetterSpaceEnactor-test.html
    M tests/framework-tests/preferences/html/LocalizationEnactor-test.html
    M tests/framework-tests/preferences/html/WordSpaceEnactor-test.html

  Log Message:
  -----------
  Merge branch 'FLUID-6278'

* FLUID-6278: (24 commits)
  FLUID-6278: Updating comment
  FLUID-6278: Cleaned up mockTTS speak override.
  FLUID-6278: Updating tests for changes to boundary event handling.
  FLUID-6278: Ignoring boundary events for "sentence" boundaries.
  FLUID-6278: Expanding test coverage for Orator tests.
  FLUID-6278: Linting
  FLUID-6278: Cleaning and updating lang values for TTS related demos.
  FLUID-6278: Updating syllabification with changes to textNodeParser
  FLUID-6278: fixing/updating tests
  FLUID-6278: Moving checkTTSSupport to tests.
  FLUID-6278: Updating TextToSpeech tests.
  FLUID-6278: Updating TextNodeParser test, and added a related bug fix.
  FLUID-6278: Refactoring and comment updates.
  FLUID-6278: Updating comments
  FLUID-6278: Refactoring of fluid.textNodeParser.parser
  FLUID-6278: In progress commit. selectionReader working.
  FLUID-6278: In progress work to update selection reader
  FLUID-6278: Broke out parseQueue array increment into separate function
  FLUID-6278: Some linting
  FLUID-6278: Updated code comments
  ...


Compare: https://github.com/fluid-project/infusion/compare/3d3b22b6a3b4...f8da9a344c2d

More information about the Commits mailing list