[Commits] [fluid-project/infusion] 3c26b6: FLUID-6431: Updating selection button rendering on...

Cindy Qi Li noreply at github.com
Thu Dec 5 21:24:10 UTC 2019


  Branch: refs/heads/master
  Home:   https://github.com/fluid-project/infusion
  Commit: 3c26b6eff1a021856b8743290429f47cf86f6765
      https://github.com/fluid-project/infusion/commit/3c26b6eff1a021856b8743290429f47cf86f6765
  Author: Justin Obara <obara.justin at gmail.com>
  Date:   2019-12-05 (Thu, 05 Dec 2019)

  Changed paths:
    M src/components/orator/js/Orator.js
    M tests/component-tests/orator/js/OratorTests-Utils.js
    M tests/component-tests/orator/js/OratorTests.js
    M tests/framework-tests/preferences/js/SelfVoicingEnactorTests.js

  Log Message:
  -----------
  FLUID-6431: Updating selection button rendering on text change.

Right Clicks in some browsers also perform a selection. In Safari and 
Chrome those selectionchange events fire twice but with the same text 
selection so there is no time where the UI would have been removed. By 
rendering the text on all selection changes, the UI is always at the 
beginning of the text and will follow right click selections.


  Commit: 46a1b887dcc4d78a78b3c3f8faaab498afc782cd
      https://github.com/fluid-project/infusion/commit/46a1b887dcc4d78a78b3c3f8faaab498afc782cd
  Author: Cindy Qi Li <cli at ocadu.ca>
  Date:   2019-12-05 (Thu, 05 Dec 2019)

  Changed paths:
    M src/components/orator/js/Orator.js
    M tests/component-tests/orator/js/OratorTests-Utils.js
    M tests/component-tests/orator/js/OratorTests.js
    M tests/framework-tests/preferences/js/SelfVoicingEnactorTests.js

  Log Message:
  -----------
  Merge remote-tracking branch 'justin/FLUID-6431'

* justin/FLUID-6431:
  FLUID-6431: Updating selection button rendering on text change.


Compare: https://github.com/fluid-project/infusion/compare/86775b03c811...46a1b887dcc4


More information about the Commits mailing list