[Commits] [fluid-project/infusion] c4cce9: FLUID-5872: Setting the iframe source programmatic...

GitHub noreply at github.com
Mon Aug 15 20:16:58 UTC 2016


  Branch: refs/heads/master
  Home:   https://github.com/fluid-project/infusion
  Commit: c4cce967e775be98fc5e477b09edfd5d105d027f
      https://github.com/fluid-project/infusion/commit/c4cce967e775be98fc5e477b09edfd5d105d027f
  Author: Justin Obara <obarajustin at gmail.com>
  Date:   2016-08-15 (Mon, 15 Aug 2016)

  Changed paths:
    M tests/component-tests/tooltip/html/Tooltip-test.html
    M tests/component-tests/tooltip/js/TooltipTests.js

  Log Message:
  -----------
  FLUID-5872: Setting the iframe source programmatically

When the iframe source was set in the document, it could load before the load event is bound.
This prevented the test from working as it was waiting for the load event.


  Commit: 975e758cde7add9dc14d6f768588f27d52d8eaaf
      https://github.com/fluid-project/infusion/commit/975e758cde7add9dc14d6f768588f27d52d8eaaf
  Author: Justin Obara <obarajustin at gmail.com>
  Date:   2016-08-15 (Mon, 15 Aug 2016)

  Changed paths:
    M tests/component-tests/tooltip/js/TooltipTests.js

  Log Message:
  -----------
  FLUID-5872: Added a comment and refactored src setting

Moved the setting of the iframe source to after the binding of the "load" listener
to ensure that the load event isn't triggered before binding to the event.


  Commit: da88fd7b88f4a60ab9a4f352fe1edbe2973afe10
      https://github.com/fluid-project/infusion/commit/da88fd7b88f4a60ab9a4f352fe1edbe2973afe10
  Author: Cindy Qi Li <cli at ocadu.ca>
  Date:   2016-08-15 (Mon, 15 Aug 2016)

  Changed paths:
    M tests/component-tests/tooltip/html/Tooltip-test.html
    M tests/component-tests/tooltip/js/TooltipTests.js

  Log Message:
  -----------
  Merge remote-tracking branch 'justin/FLUID-5872'

* justin/FLUID-5872:
  FLUID-5872: Added a comment and refactored src setting
  FLUID-5872: Setting the iframe source programmatically


Compare: https://github.com/fluid-project/infusion/compare/c8b42b771121...da88fd7b88f4


More information about the Commits mailing list