[Commits] [fluid-project/infusion] 369e3d: FLUID-4794: updating progressive enhancement

GitHub noreply at github.com
Wed Feb 13 17:01:16 EST 2013


  Branch: refs/heads/master
  Home:   https://github.com/fluid-project/infusion
  Commit: 369e3d953bb98309f7e823e381e81e7076c6ebf0
      https://github.com/fluid-project/infusion/commit/369e3d953bb98309f7e823e381e81e7076c6ebf0
  Author: Justin Obara <obarajustin at gmail.com>
  Date:   2013-02-05 (Tue, 05 Feb 2013)

  Changed paths:
    M src/webapp/framework/enhancement/js/ProgressiveEnhancement.js
    M src/webapp/tests/framework-tests/enhancement/js/ProgressiveEnhancementTests.js

  Log Message:
  -----------
  FLUID-4794: updating progressive enhancement

Adding in two new functions to the progressive enhancement: check and forget. The check function takes an object where the keys will map to the static environment if the value is a function that evaluates to true. This can be used, for example, to test browser features and only set the static environment if they exist. The forget function takes a list of keys to remove from the static environment.


  Commit: 4f3ff7ccad6b080c60123cd26e65ee2681fb49db
      https://github.com/fluid-project/infusion/commit/4f3ff7ccad6b080c60123cd26e65ee2681fb49db
  Author: Justin Obara <obarajustin at gmail.com>
  Date:   2013-02-11 (Mon, 11 Feb 2013)

  Changed paths:
    M src/webapp/framework/enhancement/js/ProgressiveEnhancement.js

  Log Message:
  -----------
  FLUID-4794: Removed deprecation comments

Removed comments about deprecating the progressive checker components and it's functions, as they will likely still be needed.


  Commit: d5eb71c8bd3fd199e42f6d3db68a4bedbbffd868
      https://github.com/fluid-project/infusion/commit/d5eb71c8bd3fd199e42f6d3db68a4bedbbffd868
  Author: Justin Obara <obarajustin at gmail.com>
  Date:   2013-02-11 (Mon, 11 Feb 2013)

  Changed paths:
    M src/webapp/framework/enhancement/js/ProgressiveEnhancement.js
    M src/webapp/tests/framework-tests/enhancement/js/ProgressiveEnhancementTests.js

  Log Message:
  -----------
  FLUID-4794: updating check to not rerun checks.

If a check is already registered in the static environment, it will not be re-run; rather the original value will be maintained. Updated the unit tests to reflect this behaviour.


  Commit: b13105bf044ec613cc9f72af4e1810230f5f4bf0
      https://github.com/fluid-project/infusion/commit/b13105bf044ec613cc9f72af4e1810230f5f4bf0
  Author: Justin Obara <obarajustin at gmail.com>
  Date:   2013-02-11 (Mon, 11 Feb 2013)

  Changed paths:
    M src/webapp/framework/enhancement/js/ProgressiveEnhancement.js
    M src/webapp/tests/framework-tests/enhancement/js/ProgressiveEnhancementTests.js

  Log Message:
  -----------
  FLUID-4794: namespaced check and forget functions

Placed the check and forget functions under the fluid.progressiveEnhancement namespaces.


  Commit: b47d38b4e1217d20efd05123230abbc17d08075d
      https://github.com/fluid-project/infusion/commit/b47d38b4e1217d20efd05123230abbc17d08075d
  Author: Justin Obara <obarajustin at gmail.com>
  Date:   2013-02-11 (Mon, 11 Feb 2013)

  Changed paths:
    M src/webapp/framework/enhancement/js/ProgressiveEnhancement.js
    M src/webapp/tests/framework-tests/enhancement/js/ProgressiveEnhancementTests.js

  Log Message:
  -----------
  FLUID-4794: type to key conversion

Added a function to convert typeNames to strings that are safe to use as keys (those that don't have "."). Replaces all "." with "-". Also added in an empty object which will hold these keys, fluid.progressiveEnhancement.checked.


  Commit: 388ad83aae459c535633402eefb4c26392e83b8a
      https://github.com/fluid-project/infusion/commit/388ad83aae459c535633402eefb4c26392e83b8a
  Author: Justin Obara <obarajustin at gmail.com>
  Date:   2013-02-11 (Mon, 11 Feb 2013)

  Changed paths:
    M src/webapp/framework/enhancement/js/ProgressiveEnhancement.js
    M src/webapp/tests/framework-tests/enhancement/js/ProgressiveEnhancementTests.js

  Log Message:
  -----------
  FLUID-4794: Updated the check function.

Updated the check function to use the fluid.progressiveEnhancement.typeToKey function to ensure that the keys in the static environment are valid. Additionally, it will record all of the keys, and the results of the check into the fluid.progressiveEnhancement.checked object. If a key is already found in the checked object, the functions will not be rerun. The forget function will be updated shortly to make use of the checked object for forgetting single and all checks.


  Commit: bafea1856ebef04e4a0256c0e4308dea07227e6f
      https://github.com/fluid-project/infusion/commit/bafea1856ebef04e4a0256c0e4308dea07227e6f
  Author: Justin Obara <obarajustin at gmail.com>
  Date:   2013-02-11 (Mon, 11 Feb 2013)

  Changed paths:
    M src/webapp/framework/enhancement/js/ProgressiveEnhancement.js
    M src/webapp/tests/framework-tests/enhancement/js/ProgressiveEnhancementTests.js

  Log Message:
  -----------
  FLUID-4794: modified the forget function

Changed fluid.progressiveEnhancement.forget to remove only a single key based on the typeTag name. It will also only remove keys that have been added via fluid.progressiveEnhancement.check. This is to prevent the removal of keys that were added by other mechanisms. In addition to the key being removed from the static environment, it is also removed from fluid.progressiveEnhancement.checked.


  Commit: b1fa08ce661fe6944e1cd2063fc09b59d916abd0
      https://github.com/fluid-project/infusion/commit/b1fa08ce661fe6944e1cd2063fc09b59d916abd0
  Author: Justin Obara <obarajustin at gmail.com>
  Date:   2013-02-11 (Mon, 11 Feb 2013)

  Changed paths:
    M src/webapp/framework/enhancement/js/ProgressiveEnhancement.js
    M src/webapp/tests/framework-tests/enhancement/js/ProgressiveEnhancementTests.js

  Log Message:
  -----------
  FLUID-4794: add a forgetAll function

Added a function, fluid.progressiveEnhancement.forgetAll to remove all the results of the checks.


  Commit: dd369bfcbe655fad44c6f535d2db5d4ac1d06429
      https://github.com/fluid-project/infusion/commit/dd369bfcbe655fad44c6f535d2db5d4ac1d06429
  Author: Justin Obara <obarajustin at gmail.com>
  Date:   2013-02-11 (Mon, 11 Feb 2013)

  Changed paths:
    M src/webapp/framework/enhancement/js/ProgressiveEnhancement.js
    M src/webapp/tests/framework-tests/enhancement/js/ProgressiveEnhancementTests.js

  Log Message:
  -----------
  FLUID-4794: refactored the typeToKey

Refactored the fluid.progressiveEnhancement.typeToKey function. It now uses an externally defined value for replacing ".". This is now set as the fluid.progressiveEnhancement.sep property and defaults to "--".


  Commit: 47f97ed5e6430688d48c7763427670349096e871
      https://github.com/fluid-project/infusion/commit/47f97ed5e6430688d48c7763427670349096e871
  Author: Justin Obara <obarajustin at gmail.com>
  Date:   2013-02-12 (Tue, 12 Feb 2013)

  Changed paths:
    M src/webapp/components/uploader/js/Uploader.js
    M src/webapp/framework/enhancement/js/ProgressiveEnhancement.js
    M src/webapp/tests/component-tests/uploader/html/ErrorPanel-test.html
    M src/webapp/tests/component-tests/uploader/html/FileQueue-test.html
    M src/webapp/tests/component-tests/uploader/html/FileQueueView-test.html
    M src/webapp/tests/component-tests/uploader/html/SWFUploadManager-test.html
    M src/webapp/tests/component-tests/uploader/js/UploaderTests.js

  Log Message:
  -----------
  FLUID-4794: progressive enhancement for uploader

Modified the progressive enhancement and uploader to work with the new check function. Also fixed the unit tests.


  Commit: 6ecbeec934a25eaac8bd34cc790ff232a4d22a00
      https://github.com/fluid-project/infusion/commit/6ecbeec934a25eaac8bd34cc790ff232a4d22a00
  Author: Justin Obara <obarajustin at gmail.com>
  Date:   2013-02-12 (Tue, 12 Feb 2013)

  Changed paths:
    M src/webapp/framework/core/js/Fluid.js
    M src/webapp/tests/framework-tests/core/js/FluidJSTests.js

  Log Message:
  -----------
  Merge branch 'master' into FLUID-4794-attempt2


  Commit: f602f80925393f7bce45bc8cfe77485f4c2c5bb4
      https://github.com/fluid-project/infusion/commit/f602f80925393f7bce45bc8cfe77485f4c2c5bb4
  Author: Justin Obara <obarajustin at gmail.com>
  Date:   2013-02-12 (Tue, 12 Feb 2013)

  Changed paths:
    M src/webapp/components/uploader/js/Uploader.js
    M src/webapp/framework/enhancement/js/ProgressiveEnhancement.js
    M src/webapp/tests/framework-tests/enhancement/js/ProgressiveEnhancementTests.js

  Log Message:
  -----------
  FLUID-4794: changing the namespace

Changed the namespace from fluid.progressiveEnhancement to fluid.enhance


  Commit: 2f4491871251a1e11892ff4f78a64188973e91c2
      https://github.com/fluid-project/infusion/commit/2f4491871251a1e11892ff4f78a64188973e91c2
  Author: Justin Obara <obarajustin at gmail.com>
  Date:   2013-02-13 (Wed, 13 Feb 2013)

  Changed paths:
    M src/webapp/tests/framework-tests/enhancement/js/ProgressiveEnhancementTests.js

  Log Message:
  -----------
  FLUID-4794: Fixed typo


  Commit: 6156e5aa4a8f00c0e330cf718b1ef08eec34c520
      https://github.com/fluid-project/infusion/commit/6156e5aa4a8f00c0e330cf718b1ef08eec34c520
  Author: Justin Obara <obarajustin at gmail.com>
  Date:   2013-02-13 (Wed, 13 Feb 2013)

  Changed paths:
    M src/webapp/tests/framework-tests/enhancement/js/ProgressiveEnhancementTests.js

  Log Message:
  -----------
  FLUID-4794: refactored tests.

Refactored the progressive enhancement tests to remove duplicate assertion code.


  Commit: fb0af10ce97873e0ab3fa86c4a122b018a5c44a2
      https://github.com/fluid-project/infusion/commit/fb0af10ce97873e0ab3fa86c4a122b018a5c44a2
  Author: Justin Obara <obarajustin at gmail.com>
  Date:   2013-02-13 (Wed, 13 Feb 2013)

  Changed paths:
    M src/webapp/framework/enhancement/js/ProgressiveEnhancement.js

  Log Message:
  -----------
  FLUID-4794: removed hasOwnProperty

Removed the use of hasOwnProperty in favour of checking if the property is undefined or not. It should never happen that the property itself contains the value of undefined.


  Commit: 585ae84e652099a9f944d0bd8dd3fe342bff411e
      https://github.com/fluid-project/infusion/commit/585ae84e652099a9f944d0bd8dd3fe342bff411e
  Author: Antranig Basman <antranig.basman at colorado.edu>
  Date:   2013-02-13 (Wed, 13 Feb 2013)

  Changed paths:
    M src/webapp/components/uploader/js/Uploader.js
    M src/webapp/framework/core/js/Fluid.js
    M src/webapp/framework/enhancement/js/ProgressiveEnhancement.js
    M src/webapp/tests/component-tests/uploader/html/ErrorPanel-test.html
    M src/webapp/tests/component-tests/uploader/html/FileQueue-test.html
    M src/webapp/tests/component-tests/uploader/html/FileQueueView-test.html
    M src/webapp/tests/component-tests/uploader/html/SWFUploadManager-test.html
    M src/webapp/tests/component-tests/uploader/js/UploaderTests.js
    M src/webapp/tests/framework-tests/core/js/FluidJSTests.js
    M src/webapp/tests/framework-tests/enhancement/js/ProgressiveEnhancementTests.js

  Log Message:
  -----------
  Merge branch 'FLUID-4794'

* FLUID-4794:
  FLUID-4794: removed hasOwnProperty
  FLUID-4794: refactored tests.
  FLUID-4794: Fixed typo
  FLUID-4794: changing the namespace
  FLUID-4794: progressive enhancement for uploader
  FLUID-4794: refactored the typeToKey
  FLUID-4794: add a forgetAll function
  FLUID-4794: modified the forget function
  FLUID-4794: Updated the check function.
  FLUID-4794: type to key conversion
  FLUID-4794: namespaced check and forget functions
  FLUID-4794: updating check to not rerun checks.
  FLUID-4794: Removed deprecation comments
  FLUID-4915: linting
  FLUID-4915: args defaults to [] for apply
  FLUID-4794: updating progressive enhancement


Compare: https://github.com/fluid-project/infusion/compare/0e2814890cad...585ae84e6520


More information about the Commits mailing list