[Commits] svn commit: 4774

Subversion Database Process svn at thor.atrc.utoronto.ca
Wed Apr 2 18:12:05 UTC 2008


------------------------------------------------------------------------
r4774 | michelle.dsouza at utoronto.ca | 2008-04-02 14:12:05 -0400 (Wed, 02 Apr 2008) | 17 lines
Changed paths:
   M /fluid/components/trunk/src/webapp/fluid-components/js/fluid/Reorderer.js

NOJIRA: Colin's patch to put the Reorderer into a closure. [CC]
Summary of changes:

 * Wrapped the Reorderer in its own closure. This gave me a private, "this"-free spot to move functions into.
 * Moved several defaults out of the constructor and into the private space, renaming them as "default..."
 * Made the cssClasses a configurable option, since a comment suggested it was a good idea and it was easy
 * Moved the firstSelectable () method out, making it take a findItems argument instead of relying on "this"
 * Broke setupDomNode () into two separate functions that don't rely on "this" anymore:
     * bindHandlersToContainer(), which... well, the name says it all. ;)
     * addRolesToContainer(), also self-explanatory
 * Moved changeSelectedToDefault() out, making it "this"-free. It now takes the cssClasses as an arg.
 * Major changes to _setActiveItem():
    * Renamed it to selectItem()
    * Combined it with related code in handleFocus()
    * Moved it out into the truly public API, adding it as a method on Reorderer.prototype


------------------------------------------------------------------------



More information about the Commits mailing list